From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Li Zhang <zhlcindy@gmail.com>
Cc: shangw@linux.vnet.ibm.com, Alexander Graf <agraf@suse.de>,
Li Zhang <zhlcindy@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [Qemu-ppc][PATCH v5 4/4] spapr: Add support for -vga option
Date: Mon, 09 Jul 2012 07:54:55 +1000 [thread overview]
Message-ID: <1341784495.3804.1.camel@pasglop> (raw)
In-Reply-To: <CAD8of+qq0ohDO19+SChmXPuZjCxVFrq0vqR=cqBYfqLSFpTbeA@mail.gmail.com>
On Sun, 2012-07-08 at 23:08 +0800, Li Zhang wrote:
> > Are you sure we want to set these in -nographic or -vga none mode as
> well?
>
> I am not sure about this.
>
> Ben, would you please give more information about this?
Doesn't matter much. They are only useful when there is a vga adapter,
they don't hurt if there isn't and it shouldn't depend on the presence
of -vga since once can add an adapter with -device, so it becomes really
tricky to figure out whether to expose them or not, so I made it
unconditional.
Cheers,
Ben.
prev parent reply other threads:[~2012-07-08 21:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 5:25 [Qemu-devel] [Qemu-ppc][PATCH v5 0/4] Add USB option and enable vga on spapr zhlcindy
2012-07-02 5:25 ` [Qemu-devel] [Qemu-ppc][PATCH v5 1/4] Add usb option in machine options zhlcindy
2012-07-06 13:43 ` Alexander Graf
2012-07-06 15:58 ` Andreas Färber
2012-07-06 16:03 ` Alexander Graf
2012-07-06 16:08 ` Andreas Färber
2012-07-08 14:46 ` Li Zhang
2012-07-08 15:02 ` Alexander Graf
2012-07-08 15:15 ` Li Zhang
2012-07-08 14:21 ` Li Zhang
2012-07-08 14:45 ` Alexander Graf
2012-07-08 14:52 ` Li Zhang
2012-07-02 5:25 ` [Qemu-devel] [Qemu-ppc][PATCH v5 2/4] Add one new file vga-pci.h zhlcindy
2012-07-03 7:17 ` [Qemu-devel] [Qemu-ppc] [PATCH " Li Zhang
2012-07-02 5:25 ` [Qemu-devel] [Qemu-ppc][PATCH v5 3/4] Cleanup pc.h on other platforms zhlcindy
2012-07-02 5:25 ` [Qemu-devel] [Qemu-ppc][PATCH v5 4/4] spapr: Add support for -vga option zhlcindy
2012-07-06 13:50 ` Alexander Graf
2012-07-06 13:58 ` Andreas Färber
2012-07-08 15:08 ` Li Zhang
2012-07-08 21:54 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341784495.3804.1.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=shangw@linux.vnet.ibm.com \
--cc=zhlcindy@gmail.com \
--cc=zhlcindy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).