From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SnzRf-0006if-Hf for qemu-devel@nongnu.org; Sun, 08 Jul 2012 17:55:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SnzRd-0002BL-UZ for qemu-devel@nongnu.org; Sun, 08 Jul 2012 17:55:11 -0400 Message-ID: <1341784495.3804.1.camel@pasglop> From: Benjamin Herrenschmidt Date: Mon, 09 Jul 2012 07:54:55 +1000 In-Reply-To: References: <0be04c2530ab90a35e26d34cd2fdea49fa392716.1341204647.git.zhlcindy@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Subject: Re: [Qemu-devel] [Qemu-ppc][PATCH v5 4/4] spapr: Add support for -vga option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Zhang Cc: shangw@linux.vnet.ibm.com, Alexander Graf , Li Zhang , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, afaerber@suse.de On Sun, 2012-07-08 at 23:08 +0800, Li Zhang wrote: > > Are you sure we want to set these in -nographic or -vga none mode as > well? > > I am not sure about this. > > Ben, would you please give more information about this? Doesn't matter much. They are only useful when there is a vga adapter, they don't hurt if there isn't and it shouldn't depend on the presence of -vga since once can add an adapter with -device, so it becomes really tricky to figure out whether to expose them or not, so I made it unconditional. Cheers, Ben.