From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hans de Goede <hdegoede@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 4/9] usb-ehci: Fix an assert whenever isoc transfers are used
Date: Mon, 9 Jul 2012 12:20:28 +0200 [thread overview]
Message-ID: <1341829233-24381-6-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1341829233-24381-1-git-send-email-kraxel@redhat.com>
From: Hans de Goede <hdegoede@redhat.com>
hcd-ehci.c is missing an usb_packet_init() call for the ipacket UsbPacket
it uses for isoc transfers, triggering an assert (taking the entire vm down)
in usb_packet_setup as soon as any isoc transfers are done by a high speed
USB device.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/hcd-ehci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 0bdfbe8..f612610 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2581,6 +2581,7 @@ static int usb_ehci_initfn(PCIDevice *dev)
s->async_bh = qemu_bh_new(ehci_async_bh, s);
QTAILQ_INIT(&s->aqueues);
QTAILQ_INIT(&s->pqueues);
+ usb_packet_init(&s->ipacket);
qemu_register_reset(ehci_reset, s);
--
1.7.1
next prev parent reply other threads:[~2012-07-09 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 10:20 [Qemu-devel] [PULL 0/9] usb patch queue Gerd Hoffmann
2012-07-09 10:20 ` [Qemu-devel] [PATCH 1/9] ehci: fix ehci_qh_do_overlay Gerd Hoffmann
2012-07-09 10:20 ` [Qemu-devel] [PATCH] usb: split endpoint init and reset Gerd Hoffmann
2012-07-09 10:20 ` [Qemu-devel] [PATCH 2/9] ehci: fix td writeback Gerd Hoffmann
2012-07-09 10:20 ` [Qemu-devel] [PATCH 3/9] ehci: don't flush cache on doorbell rings Gerd Hoffmann
2012-07-09 10:20 ` Gerd Hoffmann [this message]
2012-07-09 10:20 ` [Qemu-devel] [PATCH 5/9] ehci: Kick async schedule on wakeup in the non companion case Gerd Hoffmann
2012-07-09 10:20 ` [Qemu-devel] [PATCH 6/9] usb-redir: Correctly handle the usb_redir_babble usbredir status Gerd Hoffmann
2012-07-09 10:20 ` [Qemu-devel] [PATCH 7/9] usb: split endpoint init and reset Gerd Hoffmann
2012-07-09 10:20 ` [Qemu-devel] [PATCH 8/9] usb: fix interface initialization Gerd Hoffmann
2012-07-09 10:20 ` [Qemu-devel] [PATCH 9/9] usb-host: add trace events for iso xfers Gerd Hoffmann
2012-07-09 16:48 ` [Qemu-devel] [PULL 0/9] usb patch queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341829233-24381-6-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).