From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoB56-00026P-CQ for qemu-devel@nongnu.org; Mon, 09 Jul 2012 06:20:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoB54-0002wI-3B for qemu-devel@nongnu.org; Mon, 09 Jul 2012 06:20:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoB53-0002vd-RS for qemu-devel@nongnu.org; Mon, 09 Jul 2012 06:20:38 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q69AKajm002210 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 9 Jul 2012 06:20:36 -0400 From: Gerd Hoffmann Date: Mon, 9 Jul 2012 12:20:28 +0200 Message-Id: <1341829233-24381-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1341829233-24381-1-git-send-email-kraxel@redhat.com> References: <1341829233-24381-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 4/9] usb-ehci: Fix an assert whenever isoc transfers are used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hans de Goede , Gerd Hoffmann From: Hans de Goede hcd-ehci.c is missing an usb_packet_init() call for the ipacket UsbPacket it uses for isoc transfers, triggering an assert (taking the entire vm down) in usb_packet_setup as soon as any isoc transfers are done by a high speed USB device. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 0bdfbe8..f612610 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2581,6 +2581,7 @@ static int usb_ehci_initfn(PCIDevice *dev) s->async_bh = qemu_bh_new(ehci_async_bh, s); QTAILQ_INIT(&s->aqueues); QTAILQ_INIT(&s->pqueues); + usb_packet_init(&s->ipacket); qemu_register_reset(ehci_reset, s); -- 1.7.1