From: Alexander Graf <agraf@suse.de>
To: qemu-devel qemu-devel <qemu-devel@nongnu.org>
Cc: "Avi Kivity" <avi@redhat.com>, "Ryan Harper" <ryanh@us.ibm.com>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"KVM list" <kvm@vger.kernel.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v3 3/3] i386: KVM: List -cpu host and best in -cpu ?
Date: Mon, 9 Jul 2012 14:11:39 +0200 [thread overview]
Message-ID: <1341835899-3127-4-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1341835899-3127-1-git-send-email-agraf@suse.de>
The kvm_enabled() helper doesn't work in a function as early as -cpu ?
yet. It also doesn't make sense to list the -cpu ? output conditional on
the -enable-kvm parameter. So let's always mention -cpu host in the
CPU list when KVM is supported on that configuration.
In addition, this patch also adds listing of -cpu best in the -cpu ?
list, so that people know that this option exists.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
target-i386/cpu.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index a5d9468..0000c77 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1190,9 +1190,10 @@ void x86_cpu_list(FILE *f, fprintf_function cpu_fprintf, const char *optarg)
(*cpu_fprintf)(f, "\n");
}
}
- if (kvm_enabled()) {
- (*cpu_fprintf)(f, "x86 %16s\n", "[host]");
- }
+#ifdef CONFIG_KVM
+ (*cpu_fprintf)(f, "x86 %16s\n", "KVM only: [host]");
+ (*cpu_fprintf)(f, "x86 %16s\n", "KVM only: [best]");
+#endif
}
int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
--
1.6.0.2
prev parent reply other threads:[~2012-07-09 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 12:11 [Qemu-devel] [PATCH v3 0/3] Add -cpu best support Alexander Graf
2012-07-09 12:11 ` [Qemu-devel] [PATCH v3 1/3] KVM: Add new -cpu best Alexander Graf
2012-07-09 12:11 ` [Qemu-devel] [PATCH v3 2/3] KVM: Use -cpu best as default on x86 Alexander Graf
2012-07-09 12:11 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341835899-3127-4-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).