From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoElT-0001GI-9G for qemu-devel@nongnu.org; Mon, 09 Jul 2012 10:16:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoElQ-00085W-Jj for qemu-devel@nongnu.org; Mon, 09 Jul 2012 10:16:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoElQ-000859-Bt for qemu-devel@nongnu.org; Mon, 09 Jul 2012 10:16:36 -0400 From: Kevin Wolf Date: Mon, 9 Jul 2012 16:16:06 +0200 Message-Id: <1341843388-5663-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1341843388-5663-1-git-send-email-kwolf@redhat.com> References: <1341843388-5663-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 03/25] blockdev: warn when copy_on_read=on and readonly=on List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Hajnoczi If the image is read-only then it's not possible to copy read data into it. Therefore copy-on-read is automatically disabled for read-only images. Up until now this behavior was silent, add a warning so the user knows why copy-on-read is not working. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- blockdev.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index 9e0a72a..a85a429 100644 --- a/blockdev.c +++ b/blockdev.c @@ -609,6 +609,10 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) bdrv_flags |= ro ? 0 : BDRV_O_RDWR; + if (ro && copy_on_read) { + error_report("warning: disabling copy_on_read on readonly drive"); + } + ret = bdrv_open(dinfo->bdrv, file, bdrv_flags, drv); if (ret < 0) { error_report("could not open disk image %s: %s", -- 1.7.6.5