qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Liu Ping Fan <qemulist@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Blue Swirl" <blauwirbel@gmail.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Anthony Liguori" <anthony@codemonkey.ws>
Subject: [Qemu-devel] [PATCH 5/5] apic: create apic as a child of cpu, not system_bus any longer
Date: Tue, 10 Jul 2012 14:16:07 +0800	[thread overview]
Message-ID: <1341900967-4344-6-git-send-email-qemulist@gmail.com> (raw)
In-Reply-To: <1341900967-4344-1-git-send-email-qemulist@gmail.com>

Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
---
 hw/pc.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/pc.c b/hw/pc.c
index c7e9ab3..8df58c9 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -886,17 +886,17 @@ DeviceState *cpu_get_current_apic(void)
     }
 }
 
-static DeviceState *apic_init(void *env, uint8_t apic_id)
+static DeviceState *apic_init(void *cpu, void *env, uint8_t apic_id)
 {
     DeviceState *dev;
     static int apic_mapped;
 
     if (kvm_irqchip_in_kernel()) {
-        dev = qdev_create(NULL, "kvm-apic");
+        dev = qdev_create_kid(OBJECT(cpu), "kvm-apic");
     } else if (xen_enabled()) {
-        dev = qdev_create(NULL, "xen-apic");
+        dev = qdev_create_kid(OBJECT(cpu), "xen-apic");
     } else {
-        dev = qdev_create(NULL, "apic");
+        dev = qdev_create_kid(OBJECT(cpu), "apic");
     }
 
     qdev_prop_set_uint8(dev, "id", apic_id);
@@ -945,7 +945,7 @@ static X86CPU *pc_new_cpu(const char *cpu_model)
     }
     env = &cpu->env;
     if ((env->cpuid_features & CPUID_APIC) || smp_cpus > 1) {
-        env->apic_state = apic_init(env, env->cpuid_apic_id);
+        env->apic_state = apic_init(cpu, env, env->cpuid_apic_id);
     }
     qemu_register_reset(pc_cpu_reset, cpu);
     pc_cpu_reset(cpu);
-- 
1.7.4.4

  parent reply	other threads:[~2012-07-10  6:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10  6:16 [Qemu-devel] make apic hot-plugable Liu Ping Fan
2012-07-10  6:16 ` [Qemu-devel] [PATCH 1/5] qdev: introduce qdev_create_kid(Object *parent, const char *type) Liu Ping Fan
2012-07-10  8:12   ` Andreas Färber
2012-07-10  8:45   ` Paolo Bonzini
2012-07-11  1:17     ` liu ping fan
2012-07-11  7:01       ` Paolo Bonzini
2012-07-10  6:16 ` [Qemu-devel] [PATCH 2/5] qom: introduce object_is_type_str(), so we can judge its type Liu Ping Fan
2012-07-10  8:39   ` Paolo Bonzini
2012-07-11  1:17     ` liu ping fan
2012-07-10  6:16 ` [Qemu-devel] [PATCH 3/5] qdev: export the bus reset interface Liu Ping Fan
2012-07-10  8:40   ` Paolo Bonzini
2012-07-10  6:16 ` [Qemu-devel] [PATCH 4/5] qom-cpu: during cpu reset, it will reset its child Liu Ping Fan
2012-07-10  8:41   ` Paolo Bonzini
2012-07-10 10:12     ` Andreas Färber
2012-07-11  1:17       ` liu ping fan
2012-07-11 12:37         ` Igor Mammedov
2012-07-11  1:17     ` liu ping fan
2012-07-11  7:02       ` Paolo Bonzini
2012-07-10  6:16 ` Liu Ping Fan [this message]
2012-07-10  8:45   ` [Qemu-devel] [PATCH 5/5] apic: create apic as a child of cpu, not system_bus any longer Paolo Bonzini
2012-07-10 10:41     ` Andreas Färber
2012-07-11  8:41       ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341900967-4344-6-git-send-email-qemulist@gmail.com \
    --to=qemulist@gmail.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).