* Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call [not found] <1340799048.3732.55.camel@pasglop> @ 2012-07-10 7:25 ` Benjamin Herrenschmidt 2012-07-10 8:16 ` Benjamin Herrenschmidt 0 siblings, 1 reply; 3+ messages in thread From: Benjamin Herrenschmidt @ 2012-07-10 7:25 UTC (permalink / raw) To: qemu-devel; +Cc: Alexander Graf, kvm-ppc, kvm On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote: > From: David Gibson <david@gibson.dropbear.id.au> > > This adds support for then new "reset htab" ioctl which allows qemu > to properly cleanup the MMU hash table when the guest is reset. With > the corresponding kernel support, reset of a guest now works properly. > > This also paves the way for indicating a different size hash table > to the kernel and for the kernel to be able to impose limits on > the requested size. Alex, this has a bug, if you already applied it, please sneak: > +int kvmppc_reset_htab(int shift_hint) > +{ > + uint32_t shift = shift_hint; > + > + if (kvm_check_extension(kvm_state, KVM_CAP_PPC_ALLOC_HTAB)) { The above shall be if (kvm_enabled() && .... Else it will segfault in kvm_check_extension Or let me know if I should re-submit. Cheers, Ben. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call 2012-07-10 7:25 ` [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call Benjamin Herrenschmidt @ 2012-07-10 8:16 ` Benjamin Herrenschmidt 2012-07-10 10:34 ` Alexander Graf 0 siblings, 1 reply; 3+ messages in thread From: Benjamin Herrenschmidt @ 2012-07-10 8:16 UTC (permalink / raw) To: qemu-devel; +Cc: Alexander Graf, kvm-ppc, kvm On Tue, 2012-07-10 at 17:25 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote: > > From: David Gibson <david@gibson.dropbear.id.au> > > > > This adds support for then new "reset htab" ioctl which allows qemu > > to properly cleanup the MMU hash table when the guest is reset. With > > the corresponding kernel support, reset of a guest now works properly. > > > > This also paves the way for indicating a different size hash table > > to the kernel and for the kernel to be able to impose limits on > > the requested size. > > Alex, this has a bug, if you already applied it, please sneak: Actually just drop the whole thing, it also breaks PR KVM, I need to work a bit more on it. Cheers, Ben. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call 2012-07-10 8:16 ` Benjamin Herrenschmidt @ 2012-07-10 10:34 ` Alexander Graf 0 siblings, 0 replies; 3+ messages in thread From: Alexander Graf @ 2012-07-10 10:34 UTC (permalink / raw) To: Benjamin Herrenschmidt; +Cc: qemu-devel, kvm-ppc, kvm On 10.07.2012, at 10:16, Benjamin Herrenschmidt wrote: > On Tue, 2012-07-10 at 17:25 +1000, Benjamin Herrenschmidt wrote: >> On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote: >>> From: David Gibson <david@gibson.dropbear.id.au> >>> >>> This adds support for then new "reset htab" ioctl which allows qemu >>> to properly cleanup the MMU hash table when the guest is reset. With >>> the corresponding kernel support, reset of a guest now works properly. >>> >>> This also paves the way for indicating a different size hash table >>> to the kernel and for the kernel to be able to impose limits on >>> the requested size. >> >> Alex, this has a bug, if you already applied it, please sneak: > > Actually just drop the whole thing, it also breaks PR KVM, I need > to work a bit more on it. Alrighty. Dropped :). Alex ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-10 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1340799048.3732.55.camel@pasglop>
2012-07-10 7:25 ` [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call Benjamin Herrenschmidt
2012-07-10 8:16 ` Benjamin Herrenschmidt
2012-07-10 10:34 ` Alexander Graf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).