qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, blauwirbel@gmail.com,
	stefanha@linux.vnet.ibm.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup
Date: Tue, 10 Jul 2012 11:12:26 +0200	[thread overview]
Message-ID: <1341911575-7306-1-git-send-email-armbru@redhat.com> (raw)

29 patches may look discouraging, but most patches are small, and the
ones that aren't just move code around.

Goals of this series:

1. One more step towards a clean separation block device host and
   guest part.

2. Purge CHS geometry from the block layer

Part I    [PATCH    01/29]: Floppy geometry

Part II   [PATCH 02-03/29]: vvfat geometry bug fixes

Part III  [PATCH 04-10/29]: Clean up hard disk geometry guessing code

Part IV   [PATCH 11-12/29]: Clean up CMOS hard disk info setup

Part V    [PATCH 13-24/29]: qdev properties for disk geometry

Part VI   [PATCH 25-29/29]: A few more fixes and cleanups

A few more cleanups are in the works, in particular geometry checking
code duplication pointed out by Kevin.

This patch series is also available at
git://repo.or.cz/qemu/armbru.git
tag geo-v3

v3: Rebase; drop the three patches that have been committed already
    Fix uninitialized variable in PATCH 02/29 (Anthony)

v2: New hw/block-common.h (Blue & Kevin)
    Coding style here & there (Blue)
    Tracepoint parameter types (Stefan)

Markus Armbruster (29):
  fdc: Move floppy geometry guessing back from block.c
  vvfat: Fix partition table
  vvfat: Do not clobber the user's geometry
  qtest: Add hard disk geometry test
  hd-geometry: Move disk geometry guessing back from block.c
  hd-geometry: Add tracepoints
  hd-geometry: Unnest conditional in hd_geometry_guess()
  hd-geometry: Factor out guess_chs_for_size()
  hd-geometry: Clean up gratuitous goto in hd_geometry_guess()
  hd-geometry: Clean up confusing use of prior translation hint
  hd-geometry: Cut out block layer translation middleman
  ide pc: Cut out the block layer geometry middleman
  blockdev: Save geometry in DriveInfo
  qdev: Introduce block geometry properties
  hd-geometry: Switch to uint32_t to match BlockConf
  scsi-hd: qdev properties for disk geometry
  virtio-blk: qdev properties for disk geometry
  ide: qdev properties for disk geometry
  qtest: Cover qdev properties for disk geometry
  qdev: Collect private helpers in one place
  qdev: New property type chs-translation
  ide: qdev property for BIOS CHS translation
  qtest: Cover qdev property for BIOS CHS translation
  block: Geometry and translation hints are now useless, purge them
  ide pc: Put hard disk info into CMOS only for hard disks
  qtest: Test we don't put hard disk info into CMOS for a CD-ROM
  hd-geometry: Compute BIOS CHS translation in one place
  blockdev: Drop redundant CHS validation for if=ide
  Relax IDE CHS limits from 16383,16,63 to 65535,16,255

 block.c              |  254 ------------------------------
 block.h              |   39 +----
 block/vvfat.c        |   57 ++++---
 block_int.h          |    1 -
 blockdev.c           |   24 +--
 blockdev.h           |    2 +
 hw/Makefile.objs     |    2 +-
 hw/block-common.h    |   29 ++++
 hw/fdc.c             |  122 +++++++++++++--
 hw/fdc.h             |   10 +-
 hw/hd-geometry.c     |  157 ++++++++++++++++++
 hw/ide.h             |    4 +-
 hw/ide/core.c        |   30 +++-
 hw/ide/internal.h    |    7 +-
 hw/ide/qdev.c        |   46 +++++-
 hw/pc.c              |   78 ++++------
 hw/qdev-properties.c |  160 ++++++++++---------
 hw/qdev.h            |    3 +
 hw/s390-virtio-bus.c |    1 +
 hw/scsi-disk.c       |   70 ++++++---
 hw/virtio-blk.c      |   42 ++++-
 hw/virtio-pci.c      |    1 +
 tests/Makefile       |    2 +
 tests/hd-geo-test.c  |  428 ++++++++++++++++++++++++++++++++++++++++++++++++++
 trace-events         |    4 +
 vl.c                 |    2 +-
 26 files changed, 1067 insertions(+), 508 deletions(-)
 create mode 100644 hw/block-common.h
 create mode 100644 hw/hd-geometry.c
 create mode 100644 tests/hd-geo-test.c

-- 
1.7.6.5

             reply	other threads:[~2012-07-10  9:13 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10  9:12 Markus Armbruster [this message]
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 01/29] fdc: Move floppy geometry guessing back from block.c Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 02/29] vvfat: Fix partition table Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 03/29] vvfat: Do not clobber the user's geometry Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 04/29] qtest: Add hard disk geometry test Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c Markus Armbruster
2012-07-11 13:54   ` Kevin Wolf
2012-07-11 14:35     ` Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 06/29] hd-geometry: Add tracepoints Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 07/29] hd-geometry: Unnest conditional in hd_geometry_guess() Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 08/29] hd-geometry: Factor out guess_chs_for_size() Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 09/29] hd-geometry: Clean up gratuitous goto in hd_geometry_guess() Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 10/29] hd-geometry: Clean up confusing use of prior translation hint Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 11/29] hd-geometry: Cut out block layer translation middleman Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 12/29] ide pc: Cut out the block layer geometry middleman Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 13/29] blockdev: Save geometry in DriveInfo Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 14/29] qdev: Introduce block geometry properties Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 15/29] hd-geometry: Switch to uint32_t to match BlockConf Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 16/29] scsi-hd: qdev properties for disk geometry Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 17/29] virtio-blk: " Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 18/29] ide: " Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 19/29] qtest: Cover " Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 20/29] qdev: Collect private helpers in one place Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 21/29] qdev: New property type chs-translation Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 22/29] ide: qdev property for BIOS CHS translation Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 23/29] qtest: Cover " Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 24/29] block: Geometry and translation hints are now useless, purge them Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 25/29] ide pc: Put hard disk info into CMOS only for hard disks Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 26/29] qtest: Test we don't put hard disk info into CMOS for a CD-ROM Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 27/29] hd-geometry: Compute BIOS CHS translation in one place Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 28/29] blockdev: Drop redundant CHS validation for if=ide Markus Armbruster
2012-07-10  9:12 ` [Qemu-devel] [PATCH v3 29/29] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255 Markus Armbruster
2012-07-11 15:40 ` [Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341911575-7306-1-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).