From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SobEC-00039q-BT for qemu-devel@nongnu.org; Tue, 10 Jul 2012 10:15:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SobE8-0002GL-RU for qemu-devel@nongnu.org; Tue, 10 Jul 2012 10:15:47 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:38523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SobE8-0002FT-IT for qemu-devel@nongnu.org; Tue, 10 Jul 2012 10:15:44 -0400 Received: by yenl1 with SMTP id l1so18133yen.4 for ; Tue, 10 Jul 2012 07:15:43 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 10 Jul 2012 16:15:08 +0200 Message-Id: <1341929710-21574-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1341929710-21574-1-git-send-email-pbonzini@redhat.com> References: <1341929710-21574-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 6/8] scsi-disk: fix changeable values for MODE_PAGE_R_W_ERROR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The changeable values were not all-zeros for this mode page, fix it. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index e64d659..a7f1f14 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -1058,6 +1058,9 @@ static int mode_sense_page(SCSIDiskState *s, int page, uint8_t **p_outbuf, case MODE_PAGE_R_W_ERROR: p[1] = 10; + if (page_control == 1) { /* Changeable Values */ + break; + } p[2] = 0x80; /* Automatic Write Reallocation Enabled */ if (s->qdev.type == TYPE_ROM) { p[3] = 0x20; /* Read Retry Count */ -- 1.7.10.4