qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Meador Inge <meadori@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi, paul@codesourcery.com
Subject: [Qemu-devel] [PATCH 0/2] Probe the guest memory space when using -R
Date: Tue, 10 Jul 2012 10:57:11 -0500	[thread overview]
Message-ID: <1341935833-2655-1-git-send-email-meadori@codesourcery.com> (raw)

Hi,

This patch series fixes an issue that was discussed here [1] where -R
can fail when the mapped address space fails validation.  I fixed this
issue by (1) refactoring the guest space probing code into a single
function for initialing the guest space and (2) by calling the guest space
initializing code for both the case of reserving the guest memory space
upfront (-R) and the case where the initial memory space base/size are gleaned
from an ELF image.

Tested by going through various combinations of -R <size>, -B <base>,
-B <base> -R <size>, and neither -R or -B passed.  I also ran the libstdc++
testsuite through the MIPS, ARM, and Power usermode emulators with -R set.
No regressions.

NOTE: This does not fix the problem that was raised concerning mapped the
full 32-bit address space on a 64-bit system.  That will need to be another
patch.

[1] http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg04508.html

Signed-off-by: Meador Inge <meadori@codesourcery.com>

Meador Inge (2):
  linux-user: Factor out guest space probing into a function
  linux-user: Use init_guest_space when -R and -B are specified

 linux-user/elfload.c |  162 ++++++++++++++++++++++++++++++++++++++------------
 linux-user/main.c    |   35 ++---------
 linux-user/qemu.h    |   13 +++-
 3 files changed, 139 insertions(+), 71 deletions(-)

-- 
1.7.7.6

             reply	other threads:[~2012-07-10 15:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 15:57 Meador Inge [this message]
2012-07-10 15:57 ` [Qemu-devel] [PATCH 1/2] linux-user: Factor out guest space probing into a function Meador Inge
2012-07-10 16:12   ` Peter Maydell
2012-07-25 22:26     ` Meador Inge
2012-07-10 15:57 ` [Qemu-devel] [PATCH 2/2] linux-user: Use init_guest_space when -R and -B are specified Meador Inge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341935833-2655-1-git-send-email-meadori@codesourcery.com \
    --to=meadori@codesourcery.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).