From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH 1/5] qemu-option: add alias support
Date: Tue, 10 Jul 2012 16:50:27 -0300 [thread overview]
Message-ID: <1341949831-13547-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1341949831-13547-1-git-send-email-lcapitulino@redhat.com>
It allows for specifying an alias for each option name, see next commits
examples.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
qemu-option.c | 9 ++++++++-
qemu-option.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/qemu-option.c b/qemu-option.c
index bb3886c..59a1f6e 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -616,6 +616,7 @@ static void opt_set(QemuOpts *opts, const char *name, const char *value,
bool prepend, Error **errp)
{
QemuOpt *opt;
+ const char *optname;
const QemuOptDesc *desc = opts->list->desc;
Error *local_err = NULL;
int i;
@@ -624,18 +625,24 @@ static void opt_set(QemuOpts *opts, const char *name, const char *value,
if (strcmp(desc[i].name, name) == 0) {
break;
}
+ if (desc[i].alias && strcmp(desc[i].alias, name) == 0) {
+ break;
+ }
}
if (desc[i].name == NULL) {
if (i == 0) {
/* empty list -> allow any */;
+ optname = name;
} else {
error_set(errp, QERR_INVALID_PARAMETER, name);
return;
}
+ } else {
+ optname = desc[i].name;
}
opt = g_malloc0(sizeof(*opt));
- opt->name = g_strdup(name);
+ opt->name = g_strdup(optname);
opt->opts = opts;
if (prepend) {
QTAILQ_INSERT_HEAD(&opts->head, opt, next);
diff --git a/qemu-option.h b/qemu-option.h
index 951dec3..7106d2f 100644
--- a/qemu-option.h
+++ b/qemu-option.h
@@ -94,6 +94,7 @@ enum QemuOptType {
typedef struct QemuOptDesc {
const char *name;
+ const char *alias;
enum QemuOptType type;
const char *help;
} QemuOptDesc;
--
1.7.11.1.116.g8228a23
next prev parent reply other threads:[~2012-07-10 19:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 19:50 [Qemu-devel] [PATCH 0/5]: rename machine options to use dashes Luiz Capitulino
2012-07-10 19:50 ` Luiz Capitulino [this message]
2012-07-11 7:00 ` [Qemu-devel] [PATCH 1/5] qemu-option: add alias support Markus Armbruster
2012-07-11 12:51 ` Luiz Capitulino
2012-07-10 19:50 ` [Qemu-devel] [PATCH 2/5] machine: rename kernel_irqchip to kernel-irqchip Luiz Capitulino
2012-07-10 19:50 ` [Qemu-devel] [PATCH 3/5] machine: rename kvm_shadow_mem to kvm-shadow-mem Luiz Capitulino
2012-07-10 19:50 ` [Qemu-devel] [PATCH 4/5] machine: rename phandle_start to phandle-start Luiz Capitulino
2012-07-10 19:50 ` [Qemu-devel] [PATCH 5/5] machine: rename dt_compatible to dt-compatible Luiz Capitulino
2012-07-11 7:08 ` [Qemu-devel] [PATCH 0/5]: rename machine options to use dashes Markus Armbruster
2012-07-11 7:38 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341949831-13547-2-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).