* [Qemu-devel] [PATCH 0/2] Exynos4210 RTC
@ 2012-07-11 10:03 Oleg Ogurtsov
2012-07-11 10:03 ` [Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year Oleg Ogurtsov
2012-07-11 10:03 ` [Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code Oleg Ogurtsov
0 siblings, 2 replies; 5+ messages in thread
From: Oleg Ogurtsov @ 2012-07-11 10:03 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, kyungmin.park, e.voevodin
Patches fixed calculationg for value of year and remove unnecessary code.
Oleg Ogurtsov (2):
hw/exynos4210_rtc.c: Fix calculating for value of year
hw/exynos4210_rtc.c: remove unnecessary code
hw/exynos4210_rtc.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
--
1.7.5.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year
2012-07-11 10:03 [Qemu-devel] [PATCH 0/2] Exynos4210 RTC Oleg Ogurtsov
@ 2012-07-11 10:03 ` Oleg Ogurtsov
2012-07-20 13:15 ` Peter Maydell
2012-07-11 10:03 ` [Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code Oleg Ogurtsov
1 sibling, 1 reply; 5+ messages in thread
From: Oleg Ogurtsov @ 2012-07-11 10:03 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, kyungmin.park, Oleg Ogurtsov, e.voevodin
Signed-off-by: Oleg Ogurtsov <o.ogurtsov@samsung.com>
---
hw/exynos4210_rtc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/exynos4210_rtc.c b/hw/exynos4210_rtc.c
index f781020..b42586e 100644
--- a/hw/exynos4210_rtc.c
+++ b/hw/exynos4210_rtc.c
@@ -142,7 +142,7 @@ static const VMStateDescription vmstate_exynos4210_rtc_state = {
};
#define BCD3DIGITS(x) \
- ((uint32_t)to_bcd((uint8_t)x) + \
+ ((uint32_t)to_bcd((uint8_t)(x % 100)) + \
((uint32_t)to_bcd((uint8_t)((x % 1000) / 100)) << 8))
static void check_alarm_raise(Exynos4210RTCState *s)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code
2012-07-11 10:03 [Qemu-devel] [PATCH 0/2] Exynos4210 RTC Oleg Ogurtsov
2012-07-11 10:03 ` [Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year Oleg Ogurtsov
@ 2012-07-11 10:03 ` Oleg Ogurtsov
2012-07-20 13:17 ` Peter Maydell
1 sibling, 1 reply; 5+ messages in thread
From: Oleg Ogurtsov @ 2012-07-11 10:03 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, kyungmin.park, Oleg Ogurtsov, e.voevodin
Signed-off-by: Oleg Ogurtsov <o.ogurtsov@samsung.com>
---
hw/exynos4210_rtc.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/hw/exynos4210_rtc.c b/hw/exynos4210_rtc.c
index b42586e..42a4ddc 100644
--- a/hw/exynos4210_rtc.c
+++ b/hw/exynos4210_rtc.c
@@ -510,10 +510,7 @@ static void exynos4210_rtc_reset(DeviceState *d)
{
Exynos4210RTCState *s = (Exynos4210RTCState *)d;
- struct tm tm;
-
- qemu_get_timedate(&tm, 0);
- s->current_tm = tm;
+ qemu_get_timedate(&s->current_tm, 0);
DPRINTF("Get time from host: %d-%d-%d %2d:%02d:%02d\n",
s->current_tm.tm_year, s->current_tm.tm_mon, s->current_tm.tm_mday,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year
2012-07-11 10:03 ` [Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year Oleg Ogurtsov
@ 2012-07-20 13:15 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2012-07-20 13:15 UTC (permalink / raw)
To: Oleg Ogurtsov; +Cc: kyungmin.park, qemu-devel, e.voevodin
On 11 July 2012 11:03, Oleg Ogurtsov <o.ogurtsov@samsung.com> wrote:
>
> Signed-off-by: Oleg Ogurtsov <o.ogurtsov@samsung.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code
2012-07-11 10:03 ` [Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code Oleg Ogurtsov
@ 2012-07-20 13:17 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2012-07-20 13:17 UTC (permalink / raw)
To: Oleg Ogurtsov; +Cc: kyungmin.park, qemu-devel, e.voevodin
On 11 July 2012 11:03, Oleg Ogurtsov <o.ogurtsov@samsung.com> wrote:
>
> Signed-off-by: Oleg Ogurtsov <o.ogurtsov@samsung.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-20 13:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-11 10:03 [Qemu-devel] [PATCH 0/2] Exynos4210 RTC Oleg Ogurtsov
2012-07-11 10:03 ` [Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year Oleg Ogurtsov
2012-07-20 13:15 ` Peter Maydell
2012-07-11 10:03 ` [Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code Oleg Ogurtsov
2012-07-20 13:17 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).