From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, avi@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs
Date: Wed, 11 Jul 2012 16:40:20 +0200 [thread overview]
Message-ID: <1342017621-12650-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1342017621-12650-1-git-send-email-pbonzini@redhat.com>
No reason to leave them out, and it will ensure that the dependencies
are picked up. Later we can perhaps move the files to another
directory to avoid ../ usage.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Makefile | 2 +-
qga/Makefile.objs | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 34d6a9e..1b7cd2f 100644
--- a/Makefile
+++ b/Makefile
@@ -206,7 +206,7 @@ QGALIB_GEN=$(addprefix qapi-generated/, qga-qapi-types.h qga-qapi-visit.h qga-qm
$(QGALIB_OBJ): $(QGALIB_GEN)
$(qga-obj-y) qemu-ga.o: $(QGALIB_GEN)
-qemu-ga$(EXESUF): qemu-ga.o $(qga-obj-y) $(tools-obj-y) $(qapi-obj-y) $(qobject-obj-y) $(version-obj-y) $(QGALIB_OBJ)
+qemu-ga$(EXESUF): qemu-ga.o $(qga-obj-y) $(tools-obj-y) $(qapi-obj-y) $(qobject-obj-y) $(version-obj-y)
QEMULIBS=libhw32 libhw64 libuser libdis libdis-user
diff --git a/qga/Makefile.objs b/qga/Makefile.objs
index 6a4d843..b54b9b1 100644
--- a/qga/Makefile.objs
+++ b/qga/Makefile.objs
@@ -1,3 +1,5 @@
qga-obj-y = commands.o guest-agent-command-state.o
qga-obj-$(CONFIG_POSIX) += commands-posix.o channel-posix.o
qga-obj-$(CONFIG_WIN32) += commands-win32.o channel-win32.o service-win32.o
+qga-obj-y += ../qapi-generated/qga-qapi-types.o ../qapi-generated/qga-qapi-visit.o
+qga-obj-y += ../qapi-generated/qga-qmp-marshal.o
--
1.7.10.4
next prev parent reply other threads:[~2012-07-11 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 14:40 [Qemu-devel] [PATCH 0/2] build: get all *.d files Paolo Bonzini
2012-07-11 14:40 ` Paolo Bonzini [this message]
2012-07-11 15:25 ` [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs Michael Roth
2012-07-11 15:28 ` Paolo Bonzini
2012-07-11 16:00 ` Michael Roth
2012-07-11 14:40 ` [Qemu-devel] [PATCH 2/2] build: get dependency file directories from object file names Paolo Bonzini
2012-07-24 11:38 ` Andreas Färber
2012-07-24 11:43 ` Paolo Bonzini
2012-07-24 11:53 ` Andreas Färber
2012-07-24 12:02 ` Paolo Bonzini
2012-07-24 11:17 ` [Qemu-devel] [PATCH 0/2] build: get all *.d files Paolo Bonzini
2012-07-28 12:16 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342017621-12650-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).