From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sp3zJ-0000aZ-J0 for qemu-devel@nongnu.org; Wed, 11 Jul 2012 16:58:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sp3zI-0005Y7-BL for qemu-devel@nongnu.org; Wed, 11 Jul 2012 16:58:21 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:52950 helo=linux-iscsi.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sp3zI-0005Xy-6g for qemu-devel@nongnu.org; Wed, 11 Jul 2012 16:58:20 -0400 From: "Nicholas A. Bellinger" Date: Wed, 11 Jul 2012 20:55:28 +0000 Message-Id: <1342040128-29176-1-git-send-email-nab@linux-iscsi.org> Subject: [Qemu-devel] [PATCH] hw/virtio-scsi: Set max_target=0 during vhost-scsi operation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: Stefan Hajnoczi , kvm-devel , "Michael S. Tsirkin" , Zhi Yong Wu , Nicholas Bellinger , Zhi Yong Wu , target-devel , Paolo Bonzini , lf-virt From: Nicholas Bellinger This QEMU patch sets VirtIOSCSIConfig->max_target=0 for vhost-scsi operation to restrict virtio-scsi LLD guest scanning to max_id=0 (a single target ID instance) when connected to individual tcm_vhost endpoints as requested by Paolo. This ensures that virtio-scsi LLD only attempts to scan target IDs up to VIRTIO_SCSI_MAX_TARGET when connected via virtio-scsi-raw. It's currently cut against Zhi's qemu vhost-scsi tree here: https://github.com/wuzhy/qemu/tree/vhost-scsi Cc: Stefan Hajnoczi Cc: Zhi Yong Wu Cc: Paolo Bonzini Signed-off-by: Nicholas Bellinger --- hw/virtio-scsi.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index e38cdd0..71276b6 100644 --- a/hw/virtio-scsi.c +++ b/hw/virtio-scsi.c @@ -523,7 +523,11 @@ static void virtio_scsi_get_config(VirtIODevice *vdev, stl_raw(&scsiconf->sense_size, s->sense_size); stl_raw(&scsiconf->cdb_size, s->cdb_size); stl_raw(&scsiconf->max_channel, VIRTIO_SCSI_MAX_CHANNEL); - stl_raw(&scsiconf->max_target, VIRTIO_SCSI_MAX_TARGET); + if (s->vhost_scsi) { + stl_raw(&scsiconf->max_target, 0); + } else { + stl_raw(&scsiconf->max_target, VIRTIO_SCSI_MAX_TARGET); + } stl_raw(&scsiconf->max_lun, VIRTIO_SCSI_MAX_LUN); } -- 1.7.2.5