From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpaEM-0007i6-N6 for qemu-devel@nongnu.org; Fri, 13 Jul 2012 03:24:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SpaEL-0004Pu-Lt for qemu-devel@nongnu.org; Fri, 13 Jul 2012 03:24:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpaEL-0004Pm-DE for qemu-devel@nongnu.org; Fri, 13 Jul 2012 03:24:01 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6D7O0nr013639 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Jul 2012 03:24:00 -0400 From: Juan Quintela Date: Fri, 13 Jul 2012 09:23:34 +0200 Message-Id: <1342164224-32709-13-git-send-email-quintela@redhat.com> In-Reply-To: <1342164224-32709-1-git-send-email-quintela@redhat.com> References: <1342164224-32709-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 12/22] ram: save_live_setup() we don't need to synchronize the dirty bitmap. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org 1st: we were synchonizing the dirty bitmap before calling memory_global_dirty_log_start(). 2nd: We are marking all pages as dirty anywhere, no reason to go through all the bitmap to "mark" dirty same pages twice. So, call removed. Signed-off-by: Juan Quintela --- arch_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch_init.c b/arch_init.c index b08c615..8cbf8f4 100644 --- a/arch_init.c +++ b/arch_init.c @@ -308,8 +308,6 @@ static int ram_save_setup(QEMUFile *f, void *opaque) ram_addr_t addr; RAMBlock *block; - memory_global_sync_dirty_bitmap(get_system_memory()); - bytes_transferred = 0; last_block = NULL; last_offset = 0; -- 1.7.10.4