From: minyard@acm.org
To: qemu-devel@nongnu.org
Cc: Corey Minyard <cminyard@mvista.com>
Subject: [Qemu-devel] [PATCH 03/16] vl: Move init_timer_alarm() earlier
Date: Sun, 15 Jul 2012 15:24:58 -0500 [thread overview]
Message-ID: <1342383911-6094-3-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1342383911-6094-1-git-send-email-minyard@acm.org>
From: Corey Minyard <cminyard@mvista.com>
The timers may be used in initialization, so move them earlier so they
are ready. A reconnect options will be added to qemu-char, and it uses
a timer, but the timer alarm wasn't initialized yet.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
vl.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/vl.c b/vl.c
index 52b6588..0f0bcd9 100644
--- a/vl.c
+++ b/vl.c
@@ -3245,6 +3245,11 @@ int main(int argc, char **argv, char **envp)
qemu_set_version(machine->hw_version);
}
+ if (init_timer_alarm() < 0) {
+ fprintf(stderr, "could not initialize alarm timer\n");
+ exit(1);
+ }
+
/* Init CPU def lists, based on config
* - Must be called after all the qemu_read_config_file() calls
* - Must be called before list_cpus()
@@ -3422,11 +3427,6 @@ int main(int argc, char **argv, char **envp)
os_set_line_buffering();
- if (init_timer_alarm() < 0) {
- fprintf(stderr, "could not initialize alarm timer\n");
- exit(1);
- }
-
#ifdef CONFIG_SPICE
/* spice needs the timers to be initialized by this point */
qemu_spice_init();
--
1.7.4.1
next prev parent reply other threads:[~2012-07-15 20:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 20:24 [Qemu-devel] [PATCH 01/16] smbios: Add a function to directly add an entry minyard
2012-07-15 20:24 ` [Qemu-devel] [PATCH 02/16] pc: move SMBIOS setup to after device init minyard
2012-07-15 20:24 ` minyard [this message]
2012-07-15 20:24 ` [Qemu-devel] [PATCH 04/16] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 05/16] qemu-char: Allow a chardev to reconnect if disconnected minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 06/16] qemu-char: Fix a race reporting opens and closes minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 07/16] qemu-char: remove free of chr from win_stdio_close minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 08/16] qemu-char: Close fd at end of file minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 09/16] qdev: Add a pre-firmware init capability minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 10/16] qom: release previous object when setting minyard
2012-07-16 6:24 ` Paolo Bonzini
2012-07-17 0:07 ` Corey Minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 11/16] Add a base IPMI interface minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 12/16] IPMI: Add a PC ISA type structure minyard
2012-07-16 7:16 ` Paolo Bonzini
2012-07-17 0:16 ` Corey Minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 13/16] IPMI: Add a KCS low-level interface minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 14/16] IPMI: Add a BT " minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 15/16] IPMI: Add a local BMC simulation minyard
2012-07-15 20:25 ` [Qemu-devel] [PATCH 16/16] IPMI: Add an external connection simulation interface minyard
2012-07-15 21:05 ` [Qemu-devel] [PATCH 01/16] smbios: Add a function to directly add an entry Corey Minyard
2012-07-16 15:46 ` Eric Blake
2012-07-17 0:06 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342383911-6094-3-git-send-email-minyard@acm.org \
--to=minyard@acm.org \
--cc=cminyard@mvista.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).