From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqVNq-0001ED-Kk for qemu-devel@nongnu.org; Sun, 15 Jul 2012 16:25:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqVNo-00083P-OP for qemu-devel@nongnu.org; Sun, 15 Jul 2012 16:25:38 -0400 Received: from vms173011pub.verizon.net ([206.46.173.11]:35736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqVNo-00083D-JR for qemu-devel@nongnu.org; Sun, 15 Jul 2012 16:25:36 -0400 Received: from wf-rch.minyard.home ([unknown] [173.57.151.210]) by vms173011.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0M7700KFAY27XE60@vms173011.mailsrvcs.net> for qemu-devel@nongnu.org; Sun, 15 Jul 2012 15:25:24 -0500 (CDT) From: minyard@acm.org Date: Sun, 15 Jul 2012 15:25:02 -0500 Message-id: <1342383911-6094-7-git-send-email-minyard@acm.org> In-reply-to: <1342383911-6094-1-git-send-email-minyard@acm.org> References: <1342383911-6094-1-git-send-email-minyard@acm.org> Subject: [Qemu-devel] [PATCH 07/16] qemu-char: remove free of chr from win_stdio_close List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Corey Minyard From: Corey Minyard This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 3d4302d..8fbc704 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1946,7 +1946,6 @@ static void win_stdio_close(CharDriverState *chr) } g_free(chr->opaque); - g_free(chr); stdio_nb_clients--; } -- 1.7.4.1