From: Mike Frysinger <vapier@gentoo.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG
Date: Sun, 15 Jul 2012 16:26:12 -0400 [thread overview]
Message-ID: <1342383972-11640-1-git-send-email-vapier@gentoo.org> (raw)
We should not quote the PKG_CONFIG setting as this deviates from the
canonical upstream behavior that gets integrated with all other build
systems, and deviates from how we treat all other toolchain variables
that we get from the environment.
Ultimately, the point is that it breaks passing custom flags directly
to pkg-config via the env var where this normally works elsewhere,
and it used to work in the past.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 83fa1ca..bd12ed3 100755
--- a/configure
+++ b/configure
@@ -245,7 +245,7 @@ strip="${STRIP-${cross_prefix}strip}"
windres="${WINDRES-${cross_prefix}windres}"
pkg_config_exe="${PKG_CONFIG-${cross_prefix}pkg-config}"
query_pkg_config() {
- "${pkg_config_exe}" ${QEMU_PKG_CONFIG_FLAGS} "$@"
+ ${pkg_config_exe} ${QEMU_PKG_CONFIG_FLAGS} "$@"
}
pkg_config=query_pkg_config
sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
@@ -1511,7 +1511,7 @@ fi
##########################################
# pkg-config probe
-if ! has "$pkg_config_exe"; then
+if ! has $pkg_config_exe; then
echo "Error: pkg-config binary '$pkg_config_exe' not found"
exit 1
fi
--
1.7.9.7
next reply other threads:[~2012-07-15 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 20:26 Mike Frysinger [this message]
2012-07-15 19:54 ` [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG Stefan Weil
2012-07-15 21:53 ` Mike Frysinger
2012-07-16 15:39 ` Eric Blake
2012-07-16 15:58 ` Stefan Weil
2012-07-18 12:13 ` Mike Frysinger
2012-09-16 19:52 ` Mike Frysinger
2012-09-16 20:21 ` Stefan Weil
2012-09-17 5:24 ` Sergei Trofimovich
2012-09-17 19:38 ` Anthony Liguori
2012-09-17 19:51 ` Eric Blake
2013-06-17 6:20 ` [Qemu-devel] [PATCH v2] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342383972-11640-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).