From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqmFb-0006LQ-Eu for qemu-devel@nongnu.org; Mon, 16 Jul 2012 10:26:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqmFW-0003q4-Po for qemu-devel@nongnu.org; Mon, 16 Jul 2012 10:26:15 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:54623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqmFW-0003pt-Lm for qemu-devel@nongnu.org; Mon, 16 Jul 2012 10:26:10 -0400 Received: by yenl1 with SMTP id l1so5595734yen.4 for ; Mon, 16 Jul 2012 07:26:10 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 16 Jul 2012 16:25:52 +0200 Message-Id: <1342448756-7582-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1342448756-7582-1-git-send-email-pbonzini@redhat.com> References: <1342448756-7582-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1/5] scsi-disk: removable hard disks support START/STOP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org Support for START/STOP UNIT right now is limited to CD-ROMs. This is wrong, since removable hard disks (in the real world: SD card readers) also support it in pretty much the same way. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index bcec66b..42bae3b 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -1251,7 +1251,7 @@ static int scsi_disk_emulate_start_stop(SCSIDiskReq *r) bool start = req->cmd.buf[4] & 1; bool loej = req->cmd.buf[4] & 2; /* load on start, eject on !start */ - if (s->qdev.type == TYPE_ROM && loej) { + if ((s->features & (1 << SCSI_DISK_F_REMOVABLE)) && loej) { if (!start && !s->tray_open && s->tray_locked) { scsi_check_condition(r, bdrv_is_inserted(s->qdev.conf.bs) -- 1.7.10.4