From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sr9y9-0003co-5L for qemu-devel@nongnu.org; Tue, 17 Jul 2012 11:45:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sr9y4-00016Q-Cf for qemu-devel@nongnu.org; Tue, 17 Jul 2012 11:45:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sr9y3-000163-Kv for qemu-devel@nongnu.org; Tue, 17 Jul 2012 11:45:44 -0400 From: Amos Kong Date: Tue, 17 Jul 2012 23:45:50 +0800 Message-Id: <1342539951-30915-2-git-send-email-akong@redhat.com> In-Reply-To: <1342539951-30915-1-git-send-email-akong@redhat.com> References: <1342539951-30915-1-git-send-email-akong@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] socket: remove redundant check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: owasserm@redhat.com, aliguori@us.ibm.com, Amos Kong , mdroth@linux.vnet.ibm.com, quintela@redhat.com It's aleady in the end of loop, error should be set. Signed-off-by: Amos Kong --- qemu-sockets.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index 2ae715d..697e5d8 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -178,9 +178,7 @@ int inet_listen_opts(QemuOpts *opts, int port_offset, Error **errp) fprintf(stderr,"%s: bind(%s,%s,%d): %s\n", __FUNCTION__, inet_strfamily(e->ai_family), uaddr, inet_getport(e), strerror(errno)); - if (!e->ai_next) { - error_set(errp, QERR_SOCKET_BIND_FAILED); - } + error_set(errp, QERR_SOCKET_BIND_FAILED); } } closesocket(slisten); -- 1.7.1