From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrADO-0007cf-7q for qemu-devel@nongnu.org; Tue, 17 Jul 2012 12:01:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrADK-0005zB-3w for qemu-devel@nongnu.org; Tue, 17 Jul 2012 12:01:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrADJ-0005yq-SW for qemu-devel@nongnu.org; Tue, 17 Jul 2012 12:01:30 -0400 From: Kevin Wolf Date: Tue, 17 Jul 2012 18:00:27 +0200 Message-Id: <1342540838-9027-31-git-send-email-kwolf@redhat.com> In-Reply-To: <1342540838-9027-1-git-send-email-kwolf@redhat.com> References: <1342540838-9027-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 30/41] blockdev: Drop redundant CHS validation for if=ide List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Markus Armbruster Leave it to ide_init_drive(). Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 06c997e..5f8677e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -330,15 +330,15 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) max_devs = if_max_devs[type]; if (cyls || heads || secs) { - if (cyls < 1 || (type == IF_IDE && cyls > 16383)) { + if (cyls < 1) { error_report("invalid physical cyls number"); return NULL; } - if (heads < 1 || (type == IF_IDE && heads > 16)) { + if (heads < 1) { error_report("invalid physical heads number"); return NULL; } - if (secs < 1 || (type == IF_IDE && secs > 63)) { + if (secs < 1) { error_report("invalid physical secs number"); return NULL; } -- 1.7.6.5