From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 0/9]: qapi: generate qerrors from qapi-schema-errors.json
Date: Wed, 18 Jul 2012 14:49:11 -0300 [thread overview]
Message-ID: <1342633760-351-1-git-send-email-lcapitulino@redhat.com> (raw)
This series moves all qerrors we have today to qapi-schema-errors.json and
generate the error macros and table from it.
With this series, one doesn't have to manually add an error macro and the
matching table entry anymore. He or she just have to add the new error to
qapi-schema-errors.json.
There's only one small problem: the matching between error class name and
the (generated) error macro may not be clear for those not familirized with
qerrors. There are two possible solutions to this:
1. Add the generated macro name along with the error class name in
qapi-schema-json-errors.json; and/or
2. add docs/qapi-errors.txt to explain this in detail
This series is my first step on improving our error API.
Makefile | 8 +-
hw/qdev-properties.c | 2 +-
migration-tcp.c | 6 +-
monitor.c | 2 +-
qapi-schema-errors.json | 616 +++++++++++++++++++++++++++++++++++++++++++++++
qapi/qmp-dispatch.c | 2 +-
qapi/qmp-input-visitor.c | 2 +-
qemu-sockets.c | 22 +-
qerror.c | 310 +-----------------------
qerror.h | 220 +----------------
scripts/check-qerror.sh | 6 +-
scripts/qapi-errors.py | 180 ++++++++++++++
scripts/qapi.py | 4 +-
13 files changed, 827 insertions(+), 553 deletions(-)
next reply other threads:[~2012-07-18 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 17:49 Luiz Capitulino [this message]
2012-07-18 17:49 ` [Qemu-devel] [PATCH 1/9] qerror: rename QERR_SOCKET_* macros Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 2/9] qerror: rename QERR_SOCK_CONNECT_IN_PROGRESS Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 3/9] qerror: rename QERR_QMP_EXTRA_MEMBER Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 4/9] qerror: rename QERR_PROPERTY_VALUE_NOT_POWER_OF_2 Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 5/9] qapi: qapi.py: allow the "'" character be escaped Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 6/9] qapi: add qapi-schema-errors.json Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 7/9] qapi: add qapi-errors.py Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 8/9] qerror: switch to qapi generated error macros and table Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 9/9] scripts: update check-qerror.sh Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342633760-351-1-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).