From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 2/9] qerror: rename QERR_SOCK_CONNECT_IN_PROGRESS
Date: Wed, 18 Jul 2012 14:49:13 -0300 [thread overview]
Message-ID: <1342633760-351-3-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1342633760-351-1-git-send-email-lcapitulino@redhat.com>
The error class name is SockConnectInprogress, not SockConnectInProgress.
Rename the QERR_SOCK_CONNECT_IN_PROGRESS macro to QERR_SOCK_CONNECT_INPROGRESS
to reflect that, so that future error macro generation generates the
expected macro name.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
migration-tcp.c | 2 +-
qemu-sockets.c | 2 +-
qerror.c | 2 +-
qerror.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/migration-tcp.c b/migration-tcp.c
index 587fc70..3cffa94 100644
--- a/migration-tcp.c
+++ b/migration-tcp.c
@@ -90,7 +90,7 @@ int tcp_start_outgoing_migration(MigrationState *s, const char *host_port,
if (!error_is_set(errp)) {
migrate_fd_connect(s);
- } else if (error_is_type(*errp, QERR_SOCK_CONNECT_IN_PROGRESS)) {
+ } else if (error_is_type(*errp, QERR_SOCK_CONNECT_INPROGRESS)) {
DPRINTF("connect in progress\n");
qemu_set_fd_handler2(s->fd, NULL, NULL, tcp_wait_for_connect, s);
} else if (error_is_type(*errp, QERR_SOCK_CREATE_FAILED)) {
diff --git a/qemu-sockets.c b/qemu-sockets.c
index 1357ec0..20def3e 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -274,7 +274,7 @@ int inet_connect_opts(QemuOpts *opts, Error **errp)
#else
if (!block && (rc == -EINPROGRESS)) {
#endif
- error_set(errp, QERR_SOCK_CONNECT_IN_PROGRESS);
+ error_set(errp, QERR_SOCK_CONNECT_INPROGRESS);
} else if (rc < 0) {
if (NULL == e->ai_next)
fprintf(stderr, "%s: connect(%s,%s,%s,%s): %s\n", __FUNCTION__,
diff --git a/qerror.c b/qerror.c
index e988e36..a9d771b 100644
--- a/qerror.c
+++ b/qerror.c
@@ -309,7 +309,7 @@ static const QErrorStringTable qerror_table[] = {
.desc = "Could not start VNC server on %(target)",
},
{
- .error_fmt = QERR_SOCK_CONNECT_IN_PROGRESS,
+ .error_fmt = QERR_SOCK_CONNECT_INPROGRESS,
.desc = "Connection can not be completed immediately",
},
{
diff --git a/qerror.h b/qerror.h
index 71b0496..69d417d 100644
--- a/qerror.h
+++ b/qerror.h
@@ -251,7 +251,7 @@ QError *qobject_to_qerror(const QObject *obj);
#define QERR_VNC_SERVER_FAILED \
"{ 'class': 'VNCServerFailed', 'data': { 'target': %s } }"
-#define QERR_SOCK_CONNECT_IN_PROGRESS \
+#define QERR_SOCK_CONNECT_INPROGRESS \
"{ 'class': 'SockConnectInprogress', 'data': {} }"
#define QERR_SOCK_CONNECT_FAILED \
--
1.7.11.2.249.g31c7954.dirty
next prev parent reply other threads:[~2012-07-18 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 17:49 [Qemu-devel] [PATCH 0/9]: qapi: generate qerrors from qapi-schema-errors.json Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 1/9] qerror: rename QERR_SOCKET_* macros Luiz Capitulino
2012-07-18 17:49 ` Luiz Capitulino [this message]
2012-07-18 17:49 ` [Qemu-devel] [PATCH 3/9] qerror: rename QERR_QMP_EXTRA_MEMBER Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 4/9] qerror: rename QERR_PROPERTY_VALUE_NOT_POWER_OF_2 Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 5/9] qapi: qapi.py: allow the "'" character be escaped Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 6/9] qapi: add qapi-schema-errors.json Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 7/9] qapi: add qapi-errors.py Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 8/9] qerror: switch to qapi generated error macros and table Luiz Capitulino
2012-07-18 17:49 ` [Qemu-devel] [PATCH 9/9] scripts: update check-qerror.sh Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342633760-351-3-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).