From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SroMR-0001VB-WB for qemu-devel@nongnu.org; Thu, 19 Jul 2012 06:53:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SroMQ-0000UJ-Be for qemu-devel@nongnu.org; Thu, 19 Jul 2012 06:53:35 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:50582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SroMQ-0000U1-0x for qemu-devel@nongnu.org; Thu, 19 Jul 2012 06:53:34 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Jul 2012 11:53:32 +0100 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6JArVCT2515194 for ; Thu, 19 Jul 2012 11:53:31 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6JArURx022552 for ; Thu, 19 Jul 2012 04:53:30 -0600 From: Stefan Hajnoczi Date: Thu, 19 Jul 2012 11:52:51 +0100 Message-Id: <1342695173-32010-3-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1342695173-32010-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1342695173-32010-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 2/4] monitor: remove unused do_info_trace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Harsh Prateek Bora , qemu-devel@nongnu.org, Stefan Hajnoczi From: Harsh Prateek Bora Going forward with simpletrace v2 variable size trace records, we cannot have a generic function to print trace event info and therefore this interface becomes invalid. As per Stefan Hajnoczi: "This command is only available from the human monitor. It's not very useful because it historically hasn't been able to pretty-print events or show them in the right order (we use a ringbuffer but it prints them out from index 0). Therefore, I don't think we're under any obligation to keep this command around. No one has complained about it's limitations - I think this is a sign that no one has used it. I'd be okay with a patch that removes it." Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01268.html Signed-off-by: Harsh Prateek Bora Signed-off-by: Stefan Hajnoczi --- monitor.c | 16 ---------------- trace/simple.c | 18 ------------------ trace/simple.h | 1 - 3 files changed, 35 deletions(-) diff --git a/monitor.c b/monitor.c index 09aa3cd..49dccfe 100644 --- a/monitor.c +++ b/monitor.c @@ -941,13 +941,6 @@ static void do_info_cpu_stats(Monitor *mon) } #endif -#if defined(CONFIG_TRACE_SIMPLE) -static void do_info_trace(Monitor *mon) -{ - st_print_trace((FILE *)mon, &monitor_fprintf); -} -#endif - static void do_trace_print_events(Monitor *mon) { trace_print_events((FILE *)mon, &monitor_fprintf); @@ -2689,15 +2682,6 @@ static mon_cmd_t info_cmds[] = { .help = "show roms", .mhandler.info = do_info_roms, }, -#if defined(CONFIG_TRACE_SIMPLE) - { - .name = "trace", - .args_type = "", - .params = "", - .help = "show current contents of trace buffer", - .mhandler.info = do_info_trace, - }, -#endif { .name = "trace-events", .args_type = "", diff --git a/trace/simple.c b/trace/simple.c index b4a3c6e..b64bcf4 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -291,24 +291,6 @@ void st_print_trace_file_status(FILE *stream, int (*stream_printf)(FILE *stream, trace_file_name, trace_fp ? "on" : "off"); } -void st_print_trace(FILE *stream, int (*stream_printf)(FILE *stream, const char *fmt, ...)) -{ - unsigned int i; - - for (i = 0; i < TRACE_BUF_LEN; i++) { - TraceRecord record; - - if (!get_trace_record(i, &record)) { - continue; - } - stream_printf(stream, "Event %" PRIu64 " : %" PRIx64 " %" PRIx64 - " %" PRIx64 " %" PRIx64 " %" PRIx64 " %" PRIx64 "\n", - record.event, record.x1, record.x2, - record.x3, record.x4, record.x5, - record.x6); - } -} - void st_flush_trace_buffer(void) { flush_trace_file(true); diff --git a/trace/simple.h b/trace/simple.h index 466e75b..6b5358c 100644 --- a/trace/simple.h +++ b/trace/simple.h @@ -29,7 +29,6 @@ void trace3(TraceEventID event, uint64_t x1, uint64_t x2, uint64_t x3); void trace4(TraceEventID event, uint64_t x1, uint64_t x2, uint64_t x3, uint64_t x4); void trace5(TraceEventID event, uint64_t x1, uint64_t x2, uint64_t x3, uint64_t x4, uint64_t x5); void trace6(TraceEventID event, uint64_t x1, uint64_t x2, uint64_t x3, uint64_t x4, uint64_t x5, uint64_t x6); -void st_print_trace(FILE *stream, fprintf_function stream_printf); void st_print_trace_file_status(FILE *stream, fprintf_function stream_printf); void st_set_trace_file_enabled(bool enable); bool st_set_trace_file(const char *file); -- 1.7.10.4