From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrrQh-0007Pq-T5 for qemu-devel@nongnu.org; Thu, 19 Jul 2012 10:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrrQY-0000vc-Bp for qemu-devel@nongnu.org; Thu, 19 Jul 2012 10:10:11 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:51330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrrQX-0000pC-QW for qemu-devel@nongnu.org; Thu, 19 Jul 2012 10:10:02 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Jul 2012 14:06:33 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6JE9pLe5767604 for ; Fri, 20 Jul 2012 00:09:54 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6JE9pxi007537 for ; Fri, 20 Jul 2012 00:09:51 +1000 From: Lei Li Date: Thu, 19 Jul 2012 22:09:22 +0800 Message-Id: <1342706962-11268-1-git-send-email-lilei@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Lei Li tcp_chr_write() did not deal with writing to an unconnected connection and return the original length of the data, it's not right and would cause false writing. So (re-)connect it and return 0 for this situation. Signed-off-by: Lei Li --- qemu-char.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index c2aaaee..25eaeeb 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2141,14 +2141,17 @@ typedef struct { static void tcp_chr_accept(void *opaque); +static void tcp_chr_connect(void *opaque); + static int tcp_chr_write(CharDriverState *chr, const uint8_t *buf, int len) { TCPCharDriver *s = chr->opaque; if (s->connected) { return send_all(s->fd, buf, len); } else { - /* XXX: indicate an error ? */ - return len; + /* (Re-)connect for unconnected writing */ + tcp_chr_connect(chr); + return 0; } } -- 1.7.7.6