* [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing
@ 2012-07-19 14:09 Lei Li
2012-07-19 23:09 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Lei Li @ 2012-07-19 14:09 UTC (permalink / raw)
To: qemu-devel; +Cc: Lei Li
tcp_chr_write() did not deal with writing to an unconnected
connection and return the original length of the data, it's
not right and would cause false writing. So (re-)connect it
and return 0 for this situation.
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
qemu-char.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index c2aaaee..25eaeeb 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2141,14 +2141,17 @@ typedef struct {
static void tcp_chr_accept(void *opaque);
+static void tcp_chr_connect(void *opaque);
+
static int tcp_chr_write(CharDriverState *chr, const uint8_t *buf, int len)
{
TCPCharDriver *s = chr->opaque;
if (s->connected) {
return send_all(s->fd, buf, len);
} else {
- /* XXX: indicate an error ? */
- return len;
+ /* (Re-)connect for unconnected writing */
+ tcp_chr_connect(chr);
+ return 0;
}
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing
2012-07-19 14:09 [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing Lei Li
@ 2012-07-19 23:09 ` Anthony Liguori
2012-08-06 10:54 ` Lei Li
0 siblings, 1 reply; 4+ messages in thread
From: Anthony Liguori @ 2012-07-19 23:09 UTC (permalink / raw)
To: Lei Li, qemu-devel
Lei Li <lilei@linux.vnet.ibm.com> writes:
> tcp_chr_write() did not deal with writing to an unconnected
> connection and return the original length of the data, it's
> not right and would cause false writing. So (re-)connect it
> and return 0 for this situation.
>
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
Looks good.
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
> ---
> qemu-char.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index c2aaaee..25eaeeb 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2141,14 +2141,17 @@ typedef struct {
>
> static void tcp_chr_accept(void *opaque);
>
> +static void tcp_chr_connect(void *opaque);
> +
> static int tcp_chr_write(CharDriverState *chr, const uint8_t *buf, int len)
> {
> TCPCharDriver *s = chr->opaque;
> if (s->connected) {
> return send_all(s->fd, buf, len);
> } else {
> - /* XXX: indicate an error ? */
> - return len;
> + /* (Re-)connect for unconnected writing */
> + tcp_chr_connect(chr);
> + return 0;
> }
> }
>
> --
> 1.7.7.6
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing
2012-07-19 23:09 ` Anthony Liguori
@ 2012-08-06 10:54 ` Lei Li
0 siblings, 0 replies; 4+ messages in thread
From: Lei Li @ 2012-08-06 10:54 UTC (permalink / raw)
To: Anthony Liguori, qemu-devel; +Cc: Lei Li
Ping?
On 07/20/2012 07:09 AM, Anthony Liguori wrote:
> Lei Li <lilei@linux.vnet.ibm.com> writes:
>> tcp_chr_write() did not deal with writing to an unconnected
>> connection and return the original length of the data, it's
>> not right and would cause false writing. So (re-)connect it
>> and return 0 for this situation.
>>
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> Looks good.
>
> Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
>
> Regards,
>
> Anthony Liguori
>
>> ---
>> qemu-char.c | 7 +++++--
>> 1 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/qemu-char.c b/qemu-char.c
>> index c2aaaee..25eaeeb 100644
>> --- a/qemu-char.c
>> +++ b/qemu-char.c
>> @@ -2141,14 +2141,17 @@ typedef struct {
>>
>> static void tcp_chr_accept(void *opaque);
>>
>> +static void tcp_chr_connect(void *opaque);
>> +
>> static int tcp_chr_write(CharDriverState *chr, const uint8_t *buf, int len)
>> {
>> TCPCharDriver *s = chr->opaque;
>> if (s->connected) {
>> return send_all(s->fd, buf, len);
>> } else {
>> - /* XXX: indicate an error ? */
>> - return len;
>> + /* (Re-)connect for unconnected writing */
>> + tcp_chr_connect(chr);
>> + return 0;
>> }
>> }
>>
>> --
>> 1.7.7.6
--
Lei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing
@ 2012-07-16 2:58 Lei Li
0 siblings, 0 replies; 4+ messages in thread
From: Lei Li @ 2012-07-16 2:58 UTC (permalink / raw)
To: qemu-devel; +Cc: Lei Li
tcp_chr_write() did not deal with writing to an unconnected
connection, (re-)connect it for this situation.
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
qemu-char.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index c2aaaee..25eaeeb 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2141,14 +2141,17 @@ typedef struct {
static void tcp_chr_accept(void *opaque);
+static void tcp_chr_connect(void *opaque);
+
static int tcp_chr_write(CharDriverState *chr, const uint8_t *buf, int len)
{
TCPCharDriver *s = chr->opaque;
if (s->connected) {
return send_all(s->fd, buf, len);
} else {
- /* XXX: indicate an error ? */
- return len;
+ /* (Re-)connect for unconnected writing */
+ tcp_chr_connect(chr);
+ return 0;
}
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-06 10:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-19 14:09 [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing Lei Li
2012-07-19 23:09 ` Anthony Liguori
2012-08-06 10:54 ` Lei Li
-- strict thread matches above, loose matches on Subject: below --
2012-07-16 2:58 Lei Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).