From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Srvrk-0007mQ-4M for qemu-devel@nongnu.org; Thu, 19 Jul 2012 14:54:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Srvrg-0008CY-D0 for qemu-devel@nongnu.org; Thu, 19 Jul 2012 14:54:23 -0400 Received: from vms173017pub.verizon.net ([206.46.173.17]:23606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Srvrg-0008CG-87 for qemu-devel@nongnu.org; Thu, 19 Jul 2012 14:54:20 -0400 Received: from wf-rch.minyard.home ([unknown] [173.57.151.210]) by vms173017.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0M7F00M0D8HM0BB0@vms173017.mailsrvcs.net> for qemu-devel@nongnu.org; Thu, 19 Jul 2012 13:53:50 -0500 (CDT) From: minyard@acm.org Date: Thu, 19 Jul 2012 13:53:25 -0500 Message-id: <1342724013-1633-11-git-send-email-minyard@acm.org> In-reply-to: <1342724013-1633-1-git-send-email-minyard@acm.org> References: <1342724013-1633-1-git-send-email-minyard@acm.org> Subject: [Qemu-devel] [PATCH 10/18] qom: release previous object when setting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Corey Minyard From: Corey Minyard When setting an object, if you don't release the previous object that was there, it may become unusable. This change allows a chardev to be removed from one object's properties and added to another's. Signed-off-by: Corey Minyard Acked-by: Paolo Bonzini --- qom/object.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qom/object.c b/qom/object.c index 00bb3b0..f0ff9cc 100644 --- a/qom/object.c +++ b/qom/object.c @@ -731,6 +731,9 @@ void object_property_set(Object *obj, Visitor *v, const char *name, if (!prop->set) { error_set(errp, QERR_PERMISSION_DENIED); } else { + if (prop->release) { + prop->release(obj, name, prop->opaque); + } prop->set(obj, v, prop->opaque, name, errp); } } -- 1.7.4.1