From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Srvrl-0007nj-CH for qemu-devel@nongnu.org; Thu, 19 Jul 2012 14:54:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Srvri-0008DK-Bl for qemu-devel@nongnu.org; Thu, 19 Jul 2012 14:54:25 -0400 Received: from vms173003pub.verizon.net ([206.46.173.3]:25847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Srvri-0008Cm-4R for qemu-devel@nongnu.org; Thu, 19 Jul 2012 14:54:22 -0400 Received: from wf-rch.minyard.home ([unknown] [173.57.151.210]) by vms173003.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0M7F000RS8HNO0GB@vms173003.mailsrvcs.net> for qemu-devel@nongnu.org; Thu, 19 Jul 2012 13:53:50 -0500 (CDT) From: minyard@acm.org Date: Thu, 19 Jul 2012 13:53:22 -0500 Message-id: <1342724013-1633-8-git-send-email-minyard@acm.org> In-reply-to: <1342724013-1633-1-git-send-email-minyard@acm.org> References: <1342724013-1633-1-git-send-email-minyard@acm.org> Subject: [Qemu-devel] [PATCH 07/18] qemu-char: remove free of chr from win_stdio_close List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Corey Minyard From: Corey Minyard This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index d363319..6c3e61e 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1949,7 +1949,6 @@ static void win_stdio_close(CharDriverState *chr) } g_free(chr->opaque); - g_free(chr); stdio_nb_clients--; } -- 1.7.4.1