From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsAqV-0004r1-Bl for qemu-devel@nongnu.org; Fri, 20 Jul 2012 06:54:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsAqU-0001YB-1r for qemu-devel@nongnu.org; Fri, 20 Jul 2012 06:54:07 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:51109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsAqT-0001Wc-Rb for qemu-devel@nongnu.org; Fri, 20 Jul 2012 06:54:05 -0400 Received: by mail-pb0-f45.google.com with SMTP id ro12so5957264pbb.4 for ; Fri, 20 Jul 2012 03:54:05 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 20 Jul 2012 12:53:47 +0200 Message-Id: <1342781633-7288-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1342781633-7288-1-git-send-email-pbonzini@redhat.com> References: <1342781633-7288-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1/7] RTC: Remove the logic to update time format when DM bit changed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Zhang, Yang Z" From: "Zhang, Yang Z" Changing the DM (binary/BCD) and 24/12 control bit doesn't affect the internal registers. It only indicates what format is used for those registers. Signed-off-by: Yang Zhang Signed-off-by: Paolo Bonzini --- hw/mc146818rtc.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 9c64e0a..1ccfb50 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -220,15 +220,7 @@ static void cmos_ioport_write(void *opaque, uint32_t addr, uint32_t data) rtc_set_time(s); } } - if (((s->cmos_data[RTC_REG_B] ^ data) & (REG_B_DM | REG_B_24H)) && - !(data & REG_B_SET)) { - /* If the time format has changed and not in set mode, - update the registers immediately. */ - s->cmos_data[RTC_REG_B] = data; - rtc_copy_date(s); - } else { - s->cmos_data[RTC_REG_B] = data; - } + s->cmos_data[RTC_REG_B] = data; rtc_timer_update(s, qemu_get_clock_ns(rtc_clock)); break; case RTC_REG_C: -- 1.7.10.2