From: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
To: stefanha@gmail.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Cc: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 4/4] trace/simple.c: minor code refactoring
Date: Fri, 20 Jul 2012 18:52:15 +0530 [thread overview]
Message-ID: <1342790535-11444-5-git-send-email-harsh@linux.vnet.ibm.com> (raw)
In-Reply-To: <1342790535-11444-1-git-send-email-harsh@linux.vnet.ibm.com>
Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
---
trace/simple.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/trace/simple.c b/trace/simple.c
index 4fed07f..8e175ec 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -269,12 +269,11 @@ static unsigned int write_to_buffer(unsigned int idx, void *dataptr, size_t size
void trace_record_finish(TraceBufferRecord *rec)
{
- uint8_t temp_rec[sizeof(TraceRecord)];
- TraceRecord *record = (TraceRecord *) temp_rec;
- read_from_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord));
+ TraceRecord record;
+ read_from_buffer(rec->tbuf_idx, &record, sizeof(TraceRecord));
smp_wmb(); /* write barrier before marking as valid */
- record->event |= TRACE_RECORD_VALID;
- write_to_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord));
+ record.event |= TRACE_RECORD_VALID;
+ write_to_buffer(rec->tbuf_idx, &record, sizeof(TraceRecord));
if ((trace_idx - writeout_idx) > TRACE_BUF_FLUSH_THRESHOLD) {
flush_trace_file(false);
--
1.7.10.4
next prev parent reply other threads:[~2012-07-20 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 13:22 [Qemu-devel] [PATCH 0/4] Simpletrace v2: Code cleanup, refactoring Harsh Prateek Bora
2012-07-20 13:22 ` [Qemu-devel] [PATCH 1/4] trace/simple.c: rename TraceRecordHeader to TraceLogHeader as appropriate Harsh Prateek Bora
2012-07-20 13:22 ` [Qemu-devel] [PATCH 2/4] trace/simple.c: remove unnecessary typecasting Harsh Prateek Bora
2012-07-20 13:22 ` [Qemu-devel] [PATCH 3/4] trace/simple.c: remove obsolete code Harsh Prateek Bora
2012-07-20 13:22 ` Harsh Prateek Bora [this message]
2012-07-30 12:56 ` [Qemu-devel] [PATCH 0/4] Simpletrace v2: Code cleanup, refactoring Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342790535-11444-5-git-send-email-harsh@linux.vnet.ibm.com \
--to=harsh@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).