From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsDAw-0004sL-VW for qemu-devel@nongnu.org; Fri, 20 Jul 2012 09:23:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsDAw-0003JR-2A for qemu-devel@nongnu.org; Fri, 20 Jul 2012 09:23:22 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:46722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsDAv-0003Id-Fd for qemu-devel@nongnu.org; Fri, 20 Jul 2012 09:23:22 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Jul 2012 18:53:10 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6KDN9n010354952 for ; Fri, 20 Jul 2012 18:53:09 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6KIriK1028041 for ; Sat, 21 Jul 2012 04:53:44 +1000 From: Harsh Prateek Bora Date: Fri, 20 Jul 2012 18:52:15 +0530 Message-Id: <1342790535-11444-5-git-send-email-harsh@linux.vnet.ibm.com> In-Reply-To: <1342790535-11444-1-git-send-email-harsh@linux.vnet.ibm.com> References: <1342790535-11444-1-git-send-email-harsh@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 4/4] trace/simple.c: minor code refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stefanha@gmail.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Cc: Harsh Prateek Bora Signed-off-by: Harsh Prateek Bora --- trace/simple.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index 4fed07f..8e175ec 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -269,12 +269,11 @@ static unsigned int write_to_buffer(unsigned int idx, void *dataptr, size_t size void trace_record_finish(TraceBufferRecord *rec) { - uint8_t temp_rec[sizeof(TraceRecord)]; - TraceRecord *record = (TraceRecord *) temp_rec; - read_from_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord)); + TraceRecord record; + read_from_buffer(rec->tbuf_idx, &record, sizeof(TraceRecord)); smp_wmb(); /* write barrier before marking as valid */ - record->event |= TRACE_RECORD_VALID; - write_to_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord)); + record.event |= TRACE_RECORD_VALID; + write_to_buffer(rec->tbuf_idx, &record, sizeof(TraceRecord)); if ((trace_idx - writeout_idx) > TRACE_BUF_FLUSH_THRESHOLD) { flush_trace_file(false); -- 1.7.10.4