From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Zhi Yong Wu <wuzhy@cn.ibm.com>
Subject: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work
Date: Fri, 20 Jul 2012 14:25:51 +0100 [thread overview]
Message-ID: <1342790753-12727-1-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
The socket backend does not support the listen= option with -netdev. The
problem is how the socket NetClientState lifecycle is implemented: the socket
backend waits for an incoming client connection before creating a
NetClientState. The guest -device wants a peer= on startup, so QEMU fails with
an error about the non-existent peer.
This series makes -netdev socket,listen= work by creating the NetClientState
right away. This allows -device peer= to find the socket backend.
This code was written by Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>. I have only
cleaned up and tested it. The following work:
* -net socket,listen=:1234 -net nic,model=virtio
* -netdev socket,listen=:1234,id=netdev0 -device virtio-net-pci,netdev=netdev0
Zhi Yong Wu (2):
net: fix the coding style
net: add the support for -netdev socket, listen
net/socket.c | 82 +++++++++++++++++++++++++++++++++++-----------------------
1 file changed, 50 insertions(+), 32 deletions(-)
--
1.7.10.4
next reply other threads:[~2012-07-20 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 13:25 Stefan Hajnoczi [this message]
2012-07-20 13:25 ` [Qemu-devel] [PATCH 1/2] net: fix the coding style Stefan Hajnoczi
2012-07-20 13:25 ` [Qemu-devel] [PATCH 2/2] net: add the support for -netdev socket, listen Stefan Hajnoczi
2012-07-31 13:31 ` [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2012-07-31 11:41 Laszlo Ersek
2012-07-31 13:04 ` Stefan Hajnoczi
2012-07-31 14:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342790753-12727-1-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=wuzhy@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).