From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 5/6] qdev: Fix Open Firmware comment
Date: Sat, 21 Jul 2012 13:27:04 +0100 [thread overview]
Message-ID: <1342873625-7979-6-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1342873625-7979-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Stefan Weil <sw@weilnetz.de>
Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code,
but left the related comment at a location where it no longer
belongs to.
The patch moves the comment to the correct callback and improves the text.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
hw/qdev.h | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/hw/qdev.h b/hw/qdev.h
index 247dd1e..a2cbd9d 100644
--- a/hw/qdev.h
+++ b/hw/qdev.h
@@ -78,12 +78,6 @@ struct DeviceState {
int alias_required_for_version;
};
-/*
- * This callback is used to create Open Firmware device path in accordance with
- * OF spec http://forthworks.com/standards/of1275.pdf. Indicidual bus bindings
- * can be found here http://playground.sun.com/1275/bindings/.
- */
-
#define TYPE_BUS "bus"
#define BUS(obj) OBJECT_CHECK(BusState, (obj), TYPE_BUS)
#define BUS_CLASS(klass) OBJECT_CLASS_CHECK(BusClass, (klass), TYPE_BUS)
@@ -95,6 +89,11 @@ struct BusClass {
/* FIXME first arg should be BusState */
void (*print_dev)(Monitor *mon, DeviceState *dev, int indent);
char *(*get_dev_path)(DeviceState *dev);
+ /*
+ * This callback is used to create Open Firmware device path in accordance
+ * with OF spec http://forthworks.com/standards/of1275.pdf. Individual bus
+ * bindings can be found at http://playground.sun.com/1275/bindings/.
+ */
char *(*get_fw_dev_path)(DeviceState *dev);
int (*reset)(BusState *bus);
};
--
1.7.10.4
next prev parent reply other threads:[~2012-07-21 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 12:26 [Qemu-devel] [PULL 0/6] Trivial patches for 14 to 21 July 2012 Stefan Hajnoczi
2012-07-21 12:27 ` [Qemu-devel] [PATCH 1/6] powerpc pci: fixed packing of ranges[] Stefan Hajnoczi
2012-07-21 12:27 ` [Qemu-devel] [PATCH 2/6] Recognize PCID feature Stefan Hajnoczi
2012-07-21 12:27 ` [Qemu-devel] [PATCH 3/6] Use macro QEMU_PACKED for new packed structures Stefan Hajnoczi
2012-07-21 12:27 ` [Qemu-devel] [PATCH 4/6] cpus.c: Make all_cpu_threads_idle() static Stefan Hajnoczi
2012-07-21 12:27 ` Stefan Hajnoczi [this message]
2012-07-21 12:27 ` [Qemu-devel] [PATCH 6/6] Fix some more Qemus in documentation and help text Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342873625-7979-6-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).