From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stcwv-00007Q-8q for qemu-devel@nongnu.org; Tue, 24 Jul 2012 07:06:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Stcwr-0005vI-5h for qemu-devel@nongnu.org; Tue, 24 Jul 2012 07:06:45 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:36778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stcwr-00058R-0K for qemu-devel@nongnu.org; Tue, 24 Jul 2012 07:06:41 -0400 Received: by mail-yw0-f45.google.com with SMTP id p34so6575216yhp.4 for ; Tue, 24 Jul 2012 04:06:40 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 24 Jul 2012 13:04:19 +0200 Message-Id: <1343127865-16608-42-git-send-email-pbonzini@redhat.com> In-Reply-To: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 41/47] block: return count of dirty sectors, not chunks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, eblake@redhat.com, stefanha@linux.vnet.ibm.com This will make the API easier to use as soon as we'll let clients customize the granularity. Signed-off-by: Paolo Bonzini --- block-migration.c | 2 +- block.c | 2 +- block/mirror.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block-migration.c b/block-migration.c index b95b4e1..7ff188a 100644 --- a/block-migration.c +++ b/block-migration.c @@ -485,7 +485,7 @@ static int64_t get_remaining_dirty(void) dirty += bdrv_get_dirty_count(bmds->bs); } - return dirty * BLOCK_SIZE; + return dirty << BDRV_SECTOR_BITS; } static int is_stage2_completed(void) diff --git a/block.c b/block.c index c56a500..f3dd2a7 100644 --- a/block.c +++ b/block.c @@ -3825,7 +3825,7 @@ void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector, int64_t bdrv_get_dirty_count(BlockDriverState *bs) { if (bs->dirty_bitmap) { - return hbitmap_count(bs->dirty_bitmap) >> BDRV_LOG_SECTORS_PER_DIRTY_CHUNK; + return hbitmap_count(bs->dirty_bitmap); } else { return 0; } diff --git a/block/mirror.c b/block/mirror.c index 6f8ae62..8d242ef 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -227,7 +227,7 @@ static void coroutine_fn mirror_run(void *opaque) trace_mirror_before_sleep(s, cnt, s->synced); if (!s->synced) { /* Publish progress */ - s->common.offset = end * BDRV_SECTOR_SIZE - cnt * BLOCK_SIZE; + s->common.offset = (end - cnt) * BDRV_SECTOR_SIZE; if (s->common.speed) { delay_ns = ratelimit_calculate_delay(&s->limit, BDRV_SECTORS_PER_DIRTY_CHUNK); -- 1.7.10.4