From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
Laszlo Ersek <lersek@redhat.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Zhi Yong Wu <wuzhy@cn.ibm.com>
Subject: [Qemu-devel] [PATCH v2 09/16] net: Rename non_vlan_clients to net_clients
Date: Tue, 24 Jul 2012 16:35:12 +0100 [thread overview]
Message-ID: <1343144119-18757-10-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1343144119-18757-1-git-send-email-stefanha@linux.vnet.ibm.com>
There is no longer a distinction between vlan clients and non-vlan
clients in the net core. The net core only knows about point-to-point
clients which are connected to a peer. It's time to rename the global
list of net clients since it no longer refers to vlans at all.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
net.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/net.c b/net.c
index ee75e0e..65b45bb 100644
--- a/net.c
+++ b/net.c
@@ -47,7 +47,7 @@
# define CONFIG_NET_BRIDGE
#endif
-static QTAILQ_HEAD(, VLANClientState) non_vlan_clients;
+static QTAILQ_HEAD(, VLANClientState) net_clients;
int default_net = 1;
@@ -168,7 +168,7 @@ static char *assign_name(VLANClientState *vc1, const char *model)
char buf[256];
int id = 0;
- QTAILQ_FOREACH(vc, &non_vlan_clients, next) {
+ QTAILQ_FOREACH(vc, &net_clients, next) {
if (vc == vc1) {
continue;
}
@@ -219,7 +219,7 @@ VLANClientState *qemu_new_net_client(NetClientInfo *info,
vc->peer = peer;
peer->peer = vc;
}
- QTAILQ_INSERT_TAIL(&non_vlan_clients, vc, next);
+ QTAILQ_INSERT_TAIL(&net_clients, vc, next);
vc->send_queue = qemu_new_net_queue(qemu_deliver_packet,
qemu_deliver_packet_iov,
@@ -251,7 +251,7 @@ NICState *qemu_new_nic(NetClientInfo *info,
static void qemu_cleanup_vlan_client(VLANClientState *vc)
{
- QTAILQ_REMOVE(&non_vlan_clients, vc, next);
+ QTAILQ_REMOVE(&net_clients, vc, next);
if (vc->info->cleanup) {
vc->info->cleanup(vc);
@@ -305,7 +305,7 @@ void qemu_foreach_nic(qemu_nic_foreach func, void *opaque)
{
VLANClientState *nc;
- QTAILQ_FOREACH(nc, &non_vlan_clients, next) {
+ QTAILQ_FOREACH(nc, &net_clients, next) {
if (nc->info->type == NET_CLIENT_OPTIONS_KIND_NIC) {
func(DO_UPCAST(NICState, nc, nc), opaque);
}
@@ -470,7 +470,7 @@ VLANClientState *qemu_find_netdev(const char *id)
{
VLANClientState *vc;
- QTAILQ_FOREACH(vc, &non_vlan_clients, next) {
+ QTAILQ_FOREACH(vc, &net_clients, next) {
if (vc->info->type == NET_CLIENT_OPTIONS_KIND_NIC)
continue;
if (!strcmp(vc->name, id)) {
@@ -867,7 +867,7 @@ void do_info_network(Monitor *mon)
NetClientOptionsKind type;
monitor_printf(mon, "Devices not on any VLAN:\n");
- QTAILQ_FOREACH(vc, &non_vlan_clients, next) {
+ QTAILQ_FOREACH(vc, &net_clients, next) {
peer = vc->peer;
type = vc->info->type;
if (!peer || type == NET_CLIENT_OPTIONS_KIND_NIC) {
@@ -886,7 +886,7 @@ void qmp_set_link(const char *name, bool up, Error **errp)
{
VLANClientState *vc = NULL;
- QTAILQ_FOREACH(vc, &non_vlan_clients, next) {
+ QTAILQ_FOREACH(vc, &net_clients, next) {
if (!strcmp(vc->name, name)) {
goto done;
}
@@ -920,7 +920,7 @@ void net_cleanup(void)
{
VLANClientState *vc, *next_vc;
- QTAILQ_FOREACH_SAFE(vc, &non_vlan_clients, next, next_vc) {
+ QTAILQ_FOREACH_SAFE(vc, &net_clients, next, next_vc) {
qemu_del_vlan_client(vc);
}
}
@@ -944,7 +944,7 @@ void net_check_clients(void)
net_hub_check_clients();
- QTAILQ_FOREACH(vc, &non_vlan_clients, next) {
+ QTAILQ_FOREACH(vc, &net_clients, next) {
if (!vc->peer) {
fprintf(stderr, "Warning: %s %s has no peer\n",
vc->info->type == NET_CLIENT_OPTIONS_KIND_NIC ? "nic" : "netdev",
@@ -1008,7 +1008,7 @@ int net_init_clients(void)
#endif
}
- QTAILQ_INIT(&non_vlan_clients);
+ QTAILQ_INIT(&net_clients);
if (qemu_opts_foreach(qemu_find_opts("netdev"), net_init_netdev, NULL, 1) == -1)
return -1;
--
1.7.10.4
next prev parent reply other threads:[~2012-07-24 15:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 15:35 [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 01/16] net: Add a hub net client Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 02/16] net: Use hubs for the vlan feature Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 03/16] net: Look up 'vlan' net clients using hubs Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 04/16] hub: Check that hubs are configured correctly Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 05/16] net: Drop vlan argument to qemu_new_net_client() Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 06/16] net: Convert qdev_prop_vlan to peer with hub Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 07/16] net: Remove vlan code from net.c Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 08/16] net: Remove VLANState Stefan Hajnoczi
2012-07-24 15:35 ` Stefan Hajnoczi [this message]
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 10/16] net: Rename VLANClientState to NetClientState Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 11/16] net: Rename vc local variables to nc Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 12/16] net: Rename qemu_del_vlan_client() to qemu_del_net_client() Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 13/16] net: Make "info network" output more readable info Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 14/16] net: cleanup deliver/deliver_iov func pointers Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 15/16] net: determine if packets can be sent before net queue deliver packets Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 16/16] hub: add the support for hub own flow control Stefan Hajnoczi
2012-07-25 1:06 ` [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c Laszlo Ersek
2012-07-25 13:19 ` Laszlo Ersek
2012-07-30 15:49 ` Stefan Hajnoczi
2012-07-31 2:22 ` Zhi Yong Wu
2012-07-31 8:51 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343144119-18757-10-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wuzhy@cn.ibm.com \
--cc=wuzhy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).