From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: target-devel <target-devel@vger.kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm-devel <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Zhi Yong Wu <wuzhy@cn.ibm.com>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Hannes Reinecke <hare@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>,
lf-virt <virtualization@lists.linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] [RFC 3/9] virtio-pci: check that event notification worked
Date: Tue, 24 Jul 2012 22:34:00 +0000 [thread overview]
Message-ID: <1343169246-17636-4-git-send-email-nab@linux-iscsi.org> (raw)
In-Reply-To: <1343169246-17636-1-git-send-email-nab@linux-iscsi.org>
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
For sanity assert that event notification succeeds.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---
hw/virtio-pci.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
index 538eef4..0f0f766 100644
--- a/hw/virtio-pci.c
+++ b/hw/virtio-pci.c
@@ -261,8 +261,11 @@ static void virtio_pci_queue_notify(VirtIOPCIProxy *proxy, uint32_t n)
vq = virtio_get_queue(proxy->vdev, n);
notifier = virtio_queue_get_host_notifier(vq);
if (event_notifier_valid(notifier)) {
+ int r;
+
printf("notifying vq %u host notifier from userspace\n", n);
- event_notifier_notify(notifier);
+ r = event_notifier_notify(notifier);
+ assert(r == 0);
} else {
virtio_queue_notify_vq(vq);
}
--
1.7.2.5
next prev parent reply other threads:[~2012-07-24 22:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 22:33 [Qemu-devel] [RFC 0/9] vhost-scsi: Add support for host virtualized target Nicholas A. Bellinger
2012-07-24 22:33 ` [Qemu-devel] [RFC 1/9] notifier: add validity check and notify function Nicholas A. Bellinger
2012-07-25 6:53 ` Paolo Bonzini
2012-07-24 22:33 ` [Qemu-devel] [RFC 2/9] virtio-pci: support host notifiers in TCG mode Nicholas A. Bellinger
2012-07-25 6:50 ` Paolo Bonzini
2012-07-24 22:34 ` Nicholas A. Bellinger [this message]
2012-07-24 22:34 ` [Qemu-devel] [RFC 4/9] vhost: Pass device path to vhost_dev_init() Nicholas A. Bellinger
2012-07-24 22:34 ` [Qemu-devel] [RFC 5/9] virtio-scsi: Add wwpn and tgpt properties Nicholas A. Bellinger
2012-07-24 22:34 ` [Qemu-devel] [RFC 6/9] virtio-scsi: Open and initialize /dev/vhost-scsi Nicholas A. Bellinger
2012-07-25 7:05 ` Paolo Bonzini
2012-07-24 22:34 ` [Qemu-devel] [RFC 7/9] virtio-scsi: Start/stop vhost Nicholas A. Bellinger
2012-07-25 7:01 ` Paolo Bonzini
2012-07-25 7:03 ` Paolo Bonzini
2012-07-24 22:34 ` [Qemu-devel] [RFC 8/9] virtio-scsi: Set max_target=0 during vhost-scsi operation Nicholas A. Bellinger
2012-07-24 22:34 ` [Qemu-devel] [RFC 9/9] vhost-scsi: add -vhost-scsi host device Nicholas A. Bellinger
2012-07-25 6:58 ` Paolo Bonzini
2012-07-25 2:53 ` [Qemu-devel] [RFC 0/9] vhost-scsi: Add support for host virtualized target Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343169246-17636-4-git-send-email-nab@linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=aliguori@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzhy@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).