From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StnjG-0004dx-3b for qemu-devel@nongnu.org; Tue, 24 Jul 2012 18:37:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StnjE-00035M-KR for qemu-devel@nongnu.org; Tue, 24 Jul 2012 18:37:21 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:51121 helo=linux-iscsi.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StnjE-00035B-FL for qemu-devel@nongnu.org; Tue, 24 Jul 2012 18:37:20 -0400 From: "Nicholas A. Bellinger" Date: Tue, 24 Jul 2012 22:34:00 +0000 Message-Id: <1343169246-17636-4-git-send-email-nab@linux-iscsi.org> In-Reply-To: <1343169246-17636-1-git-send-email-nab@linux-iscsi.org> References: <1343169246-17636-1-git-send-email-nab@linux-iscsi.org> Subject: [Qemu-devel] [RFC 3/9] virtio-pci: check that event notification worked List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: target-devel Cc: Jens Axboe , Anthony Liguori , Stefan Hajnoczi , kvm-devel , "Michael S. Tsirkin" , qemu-devel , Zhi Yong Wu , Anthony Liguori , Hannes Reinecke , Paolo Bonzini , lf-virt , Christoph Hellwig From: Stefan Hajnoczi For sanity assert that event notification succeeds. Signed-off-by: Stefan Hajnoczi Cc: Anthony Liguori Cc: Paolo Bonzini Signed-off-by: Nicholas Bellinger --- hw/virtio-pci.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 538eef4..0f0f766 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -261,8 +261,11 @@ static void virtio_pci_queue_notify(VirtIOPCIProxy *proxy, uint32_t n) vq = virtio_get_queue(proxy->vdev, n); notifier = virtio_queue_get_host_notifier(vq); if (event_notifier_valid(notifier)) { + int r; + printf("notifying vq %u host notifier from userspace\n", n); - event_notifier_notify(notifier); + r = event_notifier_notify(notifier); + assert(r == 0); } else { virtio_queue_notify_vq(vq); } -- 1.7.2.5