From: benoit.canet@gmail.com
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, "Benoît Canet" <benoit@irqsave.net>,
stefanha@gmail.com, lcapitulino@redhat.com, pbonzini@redhat.com,
stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH V2 2/3] block: Use bdrv_get_backing_file_ancestors_count()
Date: Wed, 25 Jul 2012 10:11:40 +0200 [thread overview]
Message-ID: <1343203902-10524-3-git-send-email-benoit@irqsave.net> (raw)
In-Reply-To: <1343203902-10524-1-git-send-email-benoit@irqsave.net>
From: Benoît Canet <benoit@irqsave.net>
Use the dedicated counting function in qmp_query_block in order to
propagate the backing file count to HMP.
Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
block.c | 2 ++
qapi-schema.json | 9 ++++++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index 03e0860..4aa3ea9 100644
--- a/block.c
+++ b/block.c
@@ -2448,6 +2448,8 @@ BlockInfoList *qmp_query_block(Error **errp)
if (bs->backing_file[0]) {
info->value->inserted->has_backing_file = true;
info->value->inserted->backing_file = g_strdup(bs->backing_file);
+ info->value->inserted->backing_file_ancestors_count =
+ bdrv_get_backing_file_ancestors_count(bs);
}
if (bs->io_limits_enabled) {
diff --git a/qapi-schema.json b/qapi-schema.json
index a92adb1..eb72c16 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -398,6 +398,8 @@
#
# @backing_file: #optional the name of the backing file (for copy-on-write)
#
+# @backing_file_ancestors_count: #optional the count of ancestors backing files (for copy-on-write)
+#
# @encrypted: true if the backing device is encrypted
#
# @bps: total throughput limit in bytes per second is specified
@@ -418,9 +420,10 @@
##
{ 'type': 'BlockDeviceInfo',
'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str',
- '*backing_file': 'str', 'encrypted': 'bool',
- 'bps': 'int', 'bps_rd': 'int', 'bps_wr': 'int',
- 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int'} }
+ '*backing_file': 'str', 'backing_file_ancestors_count': 'int',
+ 'encrypted': 'bool', 'bps': 'int', 'bps_rd': 'int',
+ 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int',
+ 'iops_wr': 'int'} }
##
# @BlockDeviceIoStatus:
--
1.7.9.5
next prev parent reply other threads:[~2012-07-25 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 8:11 [Qemu-devel] [PATCH V2 0/3] Show backing file ancestors count in HMP benoit.canet
2012-07-25 8:11 ` [Qemu-devel] [PATCH V2 1/3] block: create bdrv_get_backing_file_ancestors_count() benoit.canet
2012-07-25 8:11 ` benoit.canet [this message]
2012-07-25 10:57 ` [Qemu-devel] [PATCH V2 2/3] block: Use bdrv_get_backing_file_ancestors_count() Kevin Wolf
2012-07-25 11:15 ` Benoît Canet
2012-07-25 11:19 ` Kevin Wolf
2012-07-25 11:42 ` Benoît Canet
2012-07-25 12:03 ` Kevin Wolf
2012-07-25 8:11 ` [Qemu-devel] [PATCH V2 3/3] hmp: show the backing file ancestors count benoit.canet
2012-07-25 10:59 ` Kevin Wolf
[not found] ` <20120725111756.GC12455@irqsave.net>
2012-07-25 11:22 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343203902-10524-3-git-send-email-benoit@irqsave.net \
--to=benoit.canet@gmail.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).