qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Khoa Huynh <khoa@us.ibm.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v2 1/7] docs: add dirty bit to qcow2 specification
Date: Wed, 25 Jul 2012 13:21:18 +0100	[thread overview]
Message-ID: <1343218884-14980-2-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1343218884-14980-1-git-send-email-stefanha@linux.vnet.ibm.com>

The dirty bit will make it possible to perform lazy refcount updates,
where the image file is not kept consistent all the time.  Upon opening
a dirty image file, it is necessary to perform a consistency check and
repair any incorrect refcounts.

Therefore the dirty bit must be an incompatible feature bit.  We don't
want old programs accessing a file with stale refcounts.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 docs/specs/qcow2.txt |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index 87bf785..339cdc1 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2.txt
@@ -75,7 +75,12 @@ in the description of a field.
                     Bitmask of incompatible features. An implementation must
                     fail to open an image if an unknown bit is set.
 
-                    Bits 0-63:  Reserved (set to 0)
+                    Bit 0:      Dirty bit.  If this bit is set then refcounts
+                                may be inconsistent, make sure to scan L1/L2
+                                tables to repair refcounts before accessing the
+                                image.
+
+                    Bits 1-63:  Reserved (set to 0)
 
          80 -  87:  compatible_features
                     Bitmask of compatible features. An implementation can
-- 
1.7.10.4

  reply	other threads:[~2012-07-25 12:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25 12:21 [Qemu-devel] [PATCH v2 0/7] qcow2: implement lazy refcounts optimization Stefan Hajnoczi
2012-07-25 12:21 ` Stefan Hajnoczi [this message]
2012-07-25 12:21 ` [Qemu-devel] [PATCH v2 2/7] qcow2: introduce dirty bit Stefan Hajnoczi
2012-07-25 12:21 ` [Qemu-devel] [PATCH v2 3/7] docs: add lazy refcounts bit to qcow2 specification Stefan Hajnoczi
2012-07-26 12:57   ` Kevin Wolf
2012-07-26 15:36     ` Stefan Hajnoczi
2012-07-25 12:21 ` [Qemu-devel] [PATCH v2 4/7] qemu-iotests: ignore qemu-img create lazy_refcounts output Stefan Hajnoczi
2012-07-25 12:21 ` [Qemu-devel] [PATCH v2 5/7] qcow2: implement lazy refcounts Stefan Hajnoczi
2012-07-26 13:15   ` Kevin Wolf
2012-07-25 12:21 ` [Qemu-devel] [PATCH v2 6/7] qemu-io: add "abort" command to simulate program crash Stefan Hajnoczi
2012-07-25 12:21 ` [Qemu-devel] [PATCH v2 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test Stefan Hajnoczi
2012-07-25 17:54   ` Eric Blake
2012-07-25 22:45     ` Stefan Hajnoczi
2012-07-25 23:41       ` Eric Blake
2012-07-26 13:28   ` Kevin Wolf
2012-07-27  7:56     ` Stefan Hajnoczi
2012-07-27  8:07       ` Kevin Wolf
2012-07-30 10:09         ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343218884-14980-2-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=khoa@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).