qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, armbru@redhat.com,
	mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2 00/11]: qapi: generate qerrors from qapi-schema-errors.json
Date: Wed, 25 Jul 2012 13:54:05 -0300	[thread overview]
Message-ID: <1343235256-26310-1-git-send-email-lcapitulino@redhat.com> (raw)

This series moves all qerrors we have today to qapi-schema-errors.json and
generates the QERR_ macros and the qerror_table[] from it.

With this series, one doesn't have to manually add an error macro and the
matching table entry anymore. He or she just have to add the new error to
qapi-schema-errors.json.

There's only one small problem: the matching between error class name and
the (generated) error macro may not be clear for those not familirized with
qerrors. There are two possible solutions to this:

  1. Add the generated macro name along with the error class name in
     qapi-schema-json-errors.json; and/or

  2. add docs/qapi-errors.txt to explain this in detail

This series is my first step on improving our error API.

o v2

 - Small qapi-errors.py improvements
 - Fix QERR_DEVICE_ENCRYPTED and QERR_AMBIGUOUS_PATH desc message

 Makefile                 |   8 +-
 hw/qdev-properties.c     |   2 +-
 migration-tcp.c          |   6 +-
 monitor.c                |   2 +-
 qapi-schema-errors.json  | 616 +++++++++++++++++++++++++++++++++++++++++++++++
 qapi/qmp-dispatch.c      |   2 +-
 qapi/qmp-input-visitor.c |   2 +-
 qemu-sockets.c           |  22 +-
 qerror.c                 | 310 +-----------------------
 qerror.h                 | 220 +----------------
 scripts/check-qerror.sh  |   6 +-
 scripts/qapi-errors.py   | 177 ++++++++++++++
 scripts/qapi.py          |   4 +-
 13 files changed, 824 insertions(+), 553 deletions(-)

             reply	other threads:[~2012-07-25 16:53 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25 16:54 Luiz Capitulino [this message]
2012-07-25 16:54 ` [Qemu-devel] [PATCH 01/11] qerror: rename QERR_SOCKET_* macros Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 02/11] qerror: rename QERR_SOCK_CONNECT_IN_PROGRESS Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 03/11] qerror: rename QERR_QMP_EXTRA_MEMBER Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 04/11] qerror: rename QERR_PROPERTY_VALUE_NOT_POWER_OF_2 Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 05/11] qerror: QERR_DEVICE_ENCRYPTED: add filename info to human msg Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 06/11] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from " Luiz Capitulino
2012-07-26 11:12   ` Markus Armbruster
2012-07-26 14:15     ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped Luiz Capitulino
2012-07-25 17:45   ` Peter Maydell
2012-07-25 19:18     ` Luiz Capitulino
2012-07-25 19:47       ` Peter Maydell
2012-07-26 11:22         ` Markus Armbruster
2012-07-26 13:47           ` Luiz Capitulino
2012-07-26 16:11             ` Markus Armbruster
2012-07-26 17:09               ` [Qemu-devel] [PATCH] fixup! " Markus Armbruster
2012-07-26 18:21                 ` Peter Maydell
2012-07-27 14:29                 ` Luiz Capitulino
2012-07-28  6:37                   ` Markus Armbruster
2012-07-30 13:09                     ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 08/11] qapi: add qapi-schema-errors.json Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py Luiz Capitulino
2012-07-26 11:50   ` Markus Armbruster
2012-07-26 11:55     ` Paolo Bonzini
2012-07-26 12:38       ` Eric Blake
2012-07-26 12:42         ` Eric Blake
2012-07-26 14:45       ` Luiz Capitulino
2012-07-26 14:34     ` Luiz Capitulino
2012-07-26 16:31       ` Markus Armbruster
2012-07-26 12:12   ` Markus Armbruster
2012-07-26 14:47     ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 10/11] qerror: switch to qapi generated error macros and table Luiz Capitulino
2012-07-26 11:56   ` Markus Armbruster
2012-07-26 14:50     ` Luiz Capitulino
2012-07-26 16:05       ` Markus Armbruster
2012-07-26 16:52         ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 11/11] scripts: update check-qerror.sh Luiz Capitulino
2012-07-26 11:57   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343235256-26310-1-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).