From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, armbru@redhat.com,
mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py
Date: Wed, 25 Jul 2012 13:54:14 -0300 [thread overview]
Message-ID: <1343235256-26310-10-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1343235256-26310-1-git-send-email-lcapitulino@redhat.com>
This script generates two files from qapi-schema-errors.json:
o qapi-errors.h: contains error macro definitions, eg. QERR_BASE_NOT_FOUND,
corresponds to most of today's qerror.h
o qapi-errors.c: contains the error table that currently exists in qerror.c
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
Makefile | 8 ++-
scripts/qapi-errors.py | 177 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 183 insertions(+), 2 deletions(-)
create mode 100644 scripts/qapi-errors.py
diff --git a/Makefile b/Makefile
index ab82ef3..2cdc732 100644
--- a/Makefile
+++ b/Makefile
@@ -22,8 +22,9 @@ GENERATED_HEADERS = config-host.h trace.h qemu-options.def
ifeq ($(TRACE_BACKEND),dtrace)
GENERATED_HEADERS += trace-dtrace.h
endif
-GENERATED_HEADERS += qmp-commands.h qapi-types.h qapi-visit.h
-GENERATED_SOURCES += qmp-marshal.c qapi-types.c qapi-visit.c trace.c
+GENERATED_HEADERS += qmp-commands.h qapi-types.h qapi-visit.h qapi-errors.h
+GENERATED_SOURCES += qmp-marshal.c qapi-types.c qapi-visit.c qapi-errors.c \
+ trace.c
# Don't try to regenerate Makefile or configure
# We don't generate any of them
@@ -200,6 +201,9 @@ $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/scripts/qapi-visit.py
qmp-commands.h qmp-marshal.c :\
$(SRC_PATH)/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py
$(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-commands.py $(gen-out-type) -m -o "." < $<, " GEN $@")
+qapi-errors.h qapi-errors.c :\
+$(SRC_PATH)/qapi-schema-errors.json $(SRC_PATH)/scripts/qapi-errors.py
+ $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-errors.py -o "." < $<, " GEN $@")
QGALIB_OBJ=$(addprefix qapi-generated/, qga-qapi-types.o qga-qapi-visit.o qga-qmp-marshal.o)
QGALIB_GEN=$(addprefix qapi-generated/, qga-qapi-types.h qga-qapi-visit.h qga-qmp-commands.h)
diff --git a/scripts/qapi-errors.py b/scripts/qapi-errors.py
new file mode 100644
index 0000000..59cf426
--- /dev/null
+++ b/scripts/qapi-errors.py
@@ -0,0 +1,177 @@
+#
+# QAPI errors generator
+#
+# Copyright (C) 2012 Red Hat, Inc.
+#
+# This work is licensed under the terms of the GNU GPLv2.
+# See the COPYING.LIB file in the top-level directory.
+
+from ordereddict import OrderedDict
+import getopt, sys, os, errno
+from qapi import *
+
+def gen_error_decl_prologue(header, guard, prefix=""):
+ ret = mcgen('''
+/* THIS FILE IS AUTOMATICALLY GENERATED, DO NOT MODIFY */
+
+/*
+ * schema-defined QAPI Errors
+ *
+ * Copyright (C) 2012 Red Hat, Inc.
+ *
+ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
+ * See the COPYING.LIB file in the top-level directory.
+ *
+ */
+
+#ifndef %(guard)s
+#define %(guard)s
+
+''',
+ header=basename(header), guard=guardname(header), prefix=prefix)
+ return ret
+
+def gen_error_def_prologue(error_header, prefix=""):
+ ret = mcgen('''
+/* THIS FILE IS AUTOMATICALLY GENERATED, DO NOT MODIFY */
+
+/*
+ * schema-defined QMP Error table
+ *
+ * Copyright (C) 2012 Red Hat, Inc.
+ *
+ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
+ * See the COPYING.LIB file in the top-level directory.
+ *
+ */
+
+#include "%(prefix)s%(error_header)s"
+
+''',
+ prefix=prefix, error_header=error_header)
+ return ret
+
+def gen_error_macro(err_domain):
+ string = ''
+ cur = err_domain[0]
+ for nxt in err_domain[1:]:
+ if string and cur.isupper() and nxt.islower():
+ string += '_'
+ string += cur
+ cur = nxt
+ string += cur
+ return 'QERR_' + string.upper()
+
+def gen_error_def_table(exprs):
+ ret = mcgen('''
+static const QErrorStringTable qerror_table[] = {
+''')
+
+ for err in exprs:
+ macro = gen_error_macro(err['error'])
+ desc = err['description']
+ ret += mcgen('''
+ {
+ .error_fmt = %(error_macro)s,
+ .desc = "%(error_desc)s",
+ },
+''',
+ error_macro=macro, error_desc=desc)
+
+ ret += mcgen('''
+ {}
+};
+''')
+
+ return ret
+
+def gen_error_macro_data_str(data):
+ colon = ''
+ data_str = ''
+ for k, v in data.items():
+ data_str += colon + "'%s': " % k
+ if v == 'str':
+ data_str += "%s"
+ elif v == 'int':
+ data_str += '%"PRId64"'
+ else:
+ sys.exit("unknown data type '%s' for error '%s'" % (v, name))
+ colon = ', '
+ return data_str
+
+def gen_error_decl_macros(exprs):
+ ret = ''
+ for err in exprs:
+ data = gen_error_macro_data_str({})
+ if err.has_key('data'):
+ data = gen_error_macro_data_str(err['data'])
+ macro = gen_error_macro(err['error'])
+ name = err['error']
+
+ ret += mcgen('''
+#define %(error_macro)s \\
+ "{ 'class': '%(error_class)s', 'data': { %(error_data)s } }"
+
+''',
+ error_macro=macro, error_class=name, error_data=data)
+ return ret
+
+def maybe_open(really, name, opt):
+ if really:
+ return open(name, opt)
+ else:
+ import StringIO
+ return StringIO.StringIO()
+
+if __name__ == '__main__':
+ try:
+ opts, args = getopt.gnu_getopt(sys.argv[1:], "chp:o:",
+ ["prefix=", "output-dir="])
+ except getopt.GetoptError, err:
+ print str(err)
+ sys.exit(1)
+
+ prefix = ""
+ output_dir = ""
+ do_c = True
+ do_h = True
+ c_file = 'qapi-errors.c'
+ h_file = 'qapi-errors.h'
+
+ for o, a in opts:
+ if o in ("-p", "--prefix"):
+ prefix = a
+ elif o in ("-o", "--output-dir"):
+ output_dir = a + "/"
+
+ c_file = output_dir + prefix + c_file
+ h_file = output_dir + prefix + h_file
+
+ try:
+ os.makedirs(output_dir)
+ except os.error, e:
+ if e.errno != errno.EEXIST:
+ raise
+
+ exprs = parse_schema(sys.stdin)
+
+ fdecl = maybe_open(do_h, h_file, 'w')
+ ret = gen_error_decl_prologue(header=basename(h_file), guard=guardname(h_file), prefix=prefix)
+ fdecl.write(ret)
+
+ ret = gen_error_decl_macros(exprs)
+ fdecl.write(ret)
+
+ fdecl.write("#endif\n")
+ fdecl.flush()
+ fdecl.close()
+
+ fdef = maybe_open(do_c, c_file, 'w')
+ ret = gen_error_def_prologue(error_header=h_file, prefix=prefix)
+ fdef.write(ret)
+
+ ret = gen_error_def_table(exprs)
+ fdef.write(ret)
+
+ fdef.flush()
+ fdef.close()
--
1.7.11.2.249.g31c7954.dirty
next prev parent reply other threads:[~2012-07-25 16:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 16:54 [Qemu-devel] [PATCH v2 00/11]: qapi: generate qerrors from qapi-schema-errors.json Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 01/11] qerror: rename QERR_SOCKET_* macros Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 02/11] qerror: rename QERR_SOCK_CONNECT_IN_PROGRESS Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 03/11] qerror: rename QERR_QMP_EXTRA_MEMBER Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 04/11] qerror: rename QERR_PROPERTY_VALUE_NOT_POWER_OF_2 Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 05/11] qerror: QERR_DEVICE_ENCRYPTED: add filename info to human msg Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 06/11] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from " Luiz Capitulino
2012-07-26 11:12 ` Markus Armbruster
2012-07-26 14:15 ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped Luiz Capitulino
2012-07-25 17:45 ` Peter Maydell
2012-07-25 19:18 ` Luiz Capitulino
2012-07-25 19:47 ` Peter Maydell
2012-07-26 11:22 ` Markus Armbruster
2012-07-26 13:47 ` Luiz Capitulino
2012-07-26 16:11 ` Markus Armbruster
2012-07-26 17:09 ` [Qemu-devel] [PATCH] fixup! " Markus Armbruster
2012-07-26 18:21 ` Peter Maydell
2012-07-27 14:29 ` Luiz Capitulino
2012-07-28 6:37 ` Markus Armbruster
2012-07-30 13:09 ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 08/11] qapi: add qapi-schema-errors.json Luiz Capitulino
2012-07-25 16:54 ` Luiz Capitulino [this message]
2012-07-26 11:50 ` [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py Markus Armbruster
2012-07-26 11:55 ` Paolo Bonzini
2012-07-26 12:38 ` Eric Blake
2012-07-26 12:42 ` Eric Blake
2012-07-26 14:45 ` Luiz Capitulino
2012-07-26 14:34 ` Luiz Capitulino
2012-07-26 16:31 ` Markus Armbruster
2012-07-26 12:12 ` Markus Armbruster
2012-07-26 14:47 ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 10/11] qerror: switch to qapi generated error macros and table Luiz Capitulino
2012-07-26 11:56 ` Markus Armbruster
2012-07-26 14:50 ` Luiz Capitulino
2012-07-26 16:05 ` Markus Armbruster
2012-07-26 16:52 ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 11/11] scripts: update check-qerror.sh Luiz Capitulino
2012-07-26 11:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343235256-26310-10-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).