From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, Jiri Denemark <jdenemar@redhat.com>,
Gleb Natapov <gleb@redhat.com>
Subject: [Qemu-devel] [QEMU PATCH 2/3] per-machine-type CPU model alias system
Date: Wed, 25 Jul 2012 15:18:42 -0300 [thread overview]
Message-ID: <1343240323-7402-3-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1343240323-7402-1-git-send-email-ehabkost@redhat.com>
This allow QEMUMachine structs to contain a list of CPU model aliases,
used to keep command-line compatibility with older machine types, while
making CPU model fixes available on newer machine types.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/boards.h | 6 ++++++
vl.c | 14 ++++++++++++++
2 files changed, 20 insertions(+)
diff --git a/hw/boards.h b/hw/boards.h
index f20f5ab..ad48399 100644
--- a/hw/boards.h
+++ b/hw/boards.h
@@ -12,6 +12,11 @@ typedef void QEMUMachineInitFunc(ram_addr_t ram_size,
const char *initrd_filename,
const char *cpu_model);
+
+typedef struct CPUModelAlias {
+ const char *alias, *cpu_model;
+} CPUModelAlias;
+
typedef struct QEMUMachine {
const char *name;
const char *alias;
@@ -27,6 +32,7 @@ typedef struct QEMUMachine {
no_sdcard:1;
int is_default;
const char *default_machine_opts;
+ struct CPUModelAlias *cpu_aliases;
GlobalProperty *compat_props;
struct QEMUMachine *next;
const char *hw_version;
diff --git a/vl.c b/vl.c
index 34cc145..cd87e06 100644
--- a/vl.c
+++ b/vl.c
@@ -1209,6 +1209,19 @@ QEMUMachine *find_default_machine(void)
return NULL;
}
+static const char *qemu_machine_resolve_cpu_model(QEMUMachine *m,
+ const char *cpu_model)
+{
+ if (cpu_model && m->cpu_aliases) {
+ CPUModelAlias *a;
+ for (a = m->cpu_aliases; a->alias; a++) {
+ if (!strcmp(cpu_model, a->alias))
+ return a->cpu_model;
+ }
+ }
+ return cpu_model;
+}
+
void qemu_machine_init(QEMUMachine *machine,
ram_addr_t ram_size,
const char *boot_devices,
@@ -1217,6 +1230,7 @@ void qemu_machine_init(QEMUMachine *machine,
const char *initrd_filename,
const char *cpu_model)
{
+ cpu_model = qemu_machine_resolve_cpu_model(machine, cpu_model);
machine->init(ram_size, boot_devices,
kernel_filename, kernel_cmdline, initrd_filename, cpu_model);
}
--
1.7.10.4
next prev parent reply other threads:[~2012-07-25 18:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 18:18 [Qemu-devel] [QEMU PATCH 0/3] versioned CPU models / per-machine-type aliases Eduardo Habkost
2012-07-25 18:18 ` [Qemu-devel] [QEMU PATCH 1/3] vl.c: extract qemu_machine_init() function Eduardo Habkost
2012-07-25 22:18 ` [Qemu-devel] [libvirt] " Eric Blake
2012-07-30 16:19 ` Eduardo Habkost
2012-07-25 18:18 ` Eduardo Habkost [this message]
2012-07-25 22:46 ` [Qemu-devel] [QEMU PATCH 2/3] per-machine-type CPU model alias system Andreas Färber
2012-07-25 18:18 ` [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names & compatibility aliases Eduardo Habkost
2012-07-25 22:52 ` Andreas Färber
2012-07-26 14:24 ` Eduardo Habkost
2012-07-26 14:31 ` Andreas Färber
2012-07-26 14:48 ` Eduardo Habkost
2012-07-31 13:22 ` Igor Mammedov
2012-07-31 13:44 ` Eduardo Habkost
2012-07-26 14:33 ` Jiri Denemark
2012-07-26 14:54 ` Eduardo Habkost
2012-07-25 23:43 ` [Qemu-devel] [QEMU PATCH 0/3] versioned CPU models / per-machine-type aliases Anthony Liguori
2012-07-26 13:53 ` Eduardo Habkost
2012-07-26 14:06 ` Andreas Färber
2012-07-26 14:29 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343240323-7402-3-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=gleb@redhat.com \
--cc=jdenemar@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).