From: Paolo Bonzini <pbonzini@redhat.com>
To: george kennedy <george.kennedy@oracle.com>
Cc: famz@redhat.com, qemu-devel@nongnu.org, boris.ostrovsky@oracle.com
Subject: Re: [Qemu-devel] [PATCH v4] lsi_scsi: Reselection needed to remove pending commands from queue
Date: Tue, 6 Nov 2018 20:15:12 +0100 [thread overview]
Message-ID: <13433232-aa9b-2bf3-a60c-a589f7e83682@redhat.com> (raw)
In-Reply-To: <5BE1E7D7.7020006@oracle.com>
On 06/11/2018 20:13, george kennedy wrote:
>
> On 11/6/2018 1:58 PM, Paolo Bonzini wrote:
>> On 31/10/2018 22:03, George Kennedy wrote:
>>> +#define SCRIPTS_LOAD_AND_STORE 0xe2340004
>> I'm very confused. Why did this constant reappear?
>
> Ok. Me too.
>
> What are you proposing instead and I'll change it to that?
>
> Did I have what you're after in a prior patch? If so, can you point to
> that clip?
No. You need to do what you're doing here after the WAIT DISCONNECT
command (which, as far as I can see, comes before the LOAD AND STORE
you're looking for). I wrote that in the reply to v3 I think.
Paolo
prev parent reply other threads:[~2018-11-06 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 21:03 [Qemu-devel] [PATCH v4] lsi_scsi: Reselection needed to remove pending commands from queue George Kennedy
2018-11-06 18:58 ` Paolo Bonzini
2018-11-06 19:13 ` george kennedy
2018-11-06 19:15 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13433232-aa9b-2bf3-a60c-a589f7e83682@redhat.com \
--to=pbonzini@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=famz@redhat.com \
--cc=george.kennedy@oracle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).