From: Ronnie Sahlberg <ronniesahlberg@gmail.com>
To: qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH] SCSI: STARTSTOPUNIT fix for PWRCND!=0
Date: Sat, 28 Jul 2012 11:14:52 +1000 [thread overview]
Message-ID: <1343438093-13151-1-git-send-email-ronniesahlberg@gmail.com> (raw)
Paolo, List
Please find a trivial fix for the STARTSTOPUNIT emulation.
This command will only eject/load media if powercondition is 0.
With this patch, QEMU SCSI emulation now pass all my SSU tests :
$ ./bin/iscsi-test --dataloss --test="*startstop*" iscsi://127.0.0.1:32601/iqn.qemu.scsi-test/3
0360_startstopunit_simple:
===================
Media is removable. STARTSTOPUNIT should work
Try to eject the media ... [OK]
Try to mount the media again ... [OK]
TEST T0360_startstopunit_simple [OK]
0361_startstopunit_pwrcnd:
===================
Media is removable. STARTSTOPUNIT should work
Try to eject media with PC != 0 ... [OK]
Try to mount the media again ... [OK]
TEST T0361_startstopunit_pwrcnd [OK]
regards
ronnie sahlberg
next reply other threads:[~2012-07-28 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 1:14 Ronnie Sahlberg [this message]
2012-07-28 1:14 ` [Qemu-devel] [PATCH] SCSI: STARTSTOPUNIT only eject/load media if powercondition is 0 Ronnie Sahlberg
2012-07-30 7:42 ` Paolo Bonzini
2012-07-30 8:20 ` Kevin Wolf
2012-07-30 8:25 ` Paolo Bonzini
2012-07-30 8:46 ` ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343438093-13151-1-git-send-email-ronniesahlberg@gmail.com \
--to=ronniesahlberg@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).