* [Qemu-devel] [PATCH] qxl/update_area_io: guest_bug on invalid parameters
@ 2012-07-29 9:55 Alon Levy
2012-07-30 10:18 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Alon Levy @ 2012-07-29 9:55 UTC (permalink / raw)
To: qemu-devel, kraxel
Signed-off-by: Alon Levy <alevy@redhat.com>
---
hw/qxl.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index 92e985b..5278541 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1405,6 +1405,18 @@ async_common:
QXLCookie *cookie = NULL;
QXLRect update = d->ram->update_area;
+ if (d->ram->update_surface > NUM_SURFACES) {
+ qxl_set_guest_bug(d, "QXL_IO_UPDATE_AREA: invalid surface id %d\n",
+ d->ram->update_surface);
+ return;
+ }
+ if (update.left >= update.right || update.top >= update.bottom) {
+ qxl_set_guest_bug(d,
+ "QXL_IO_UPDATE_AREA: invalid area (%ux%u)x(%ux%u)\n",
+ update.left, update.top, update.right, update.bottom);
+ return;
+ }
+
if (async == QXL_ASYNC) {
cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO,
QXL_IO_UPDATE_AREA_ASYNC);
--
1.7.11.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] qxl/update_area_io: guest_bug on invalid parameters
2012-07-29 9:55 [Qemu-devel] [PATCH] qxl/update_area_io: guest_bug on invalid parameters Alon Levy
@ 2012-07-30 10:18 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2012-07-30 10:18 UTC (permalink / raw)
To: Alon Levy; +Cc: qemu-devel, kraxel
Acked-by: Hans de Goede <hdegoede@redhat.com>
On 07/29/2012 11:55 AM, Alon Levy wrote:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> hw/qxl.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/hw/qxl.c b/hw/qxl.c
> index 92e985b..5278541 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -1405,6 +1405,18 @@ async_common:
> QXLCookie *cookie = NULL;
> QXLRect update = d->ram->update_area;
>
> + if (d->ram->update_surface > NUM_SURFACES) {
> + qxl_set_guest_bug(d, "QXL_IO_UPDATE_AREA: invalid surface id %d\n",
> + d->ram->update_surface);
> + return;
> + }
> + if (update.left >= update.right || update.top >= update.bottom) {
> + qxl_set_guest_bug(d,
> + "QXL_IO_UPDATE_AREA: invalid area (%ux%u)x(%ux%u)\n",
> + update.left, update.top, update.right, update.bottom);
> + return;
> + }
> +
> if (async == QXL_ASYNC) {
> cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO,
> QXL_IO_UPDATE_AREA_ASYNC);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-30 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-29 9:55 [Qemu-devel] [PATCH] qxl/update_area_io: guest_bug on invalid parameters Alon Levy
2012-07-30 10:18 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).