From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvbPX-00078t-TN for qemu-devel@nongnu.org; Sun, 29 Jul 2012 17:52:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvbPW-0003gp-Rc for qemu-devel@nongnu.org; Sun, 29 Jul 2012 17:52:27 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:34874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvbPW-0003fQ-Lv for qemu-devel@nongnu.org; Sun, 29 Jul 2012 17:52:26 -0400 Received: by mail-pb0-f45.google.com with SMTP id ro12so8308161pbb.4 for ; Sun, 29 Jul 2012 14:52:26 -0700 (PDT) From: Ronnie Sahlberg Date: Mon, 30 Jul 2012 07:52:03 +1000 Message-Id: <1343598723-12299-2-git-send-email-ronniesahlberg@gmail.com> In-Reply-To: <1343598723-12299-1-git-send-email-ronniesahlberg@gmail.com> References: <1343598723-12299-1-git-send-email-ronniesahlberg@gmail.com> Subject: [Qemu-devel] [PATCH] SCSI: Update the sense code for PREVENT REMOVAL errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, pbonzini@redhat.com Cc: Ronnie Sahlberg Change the sense codes for failures to eject a device that is locked by PREVENT_ALLOW_MEDIUM_REMOVAL from the generic MEDIA_LOAD_OR_EJECT_FAILED to the more specific MEDIUM_REMOVAL_PREVENTED. The second sense code is more accurate, and is also listed in MMC annex F for the recommended sense codes for MMC devices while the first sense code is not. Signed-off-by: Ronnie Sahlberg --- hw/scsi-bus.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index dc74063..9929d3c 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -1089,7 +1089,7 @@ const struct SCSISense sense_code_NO_MEDIUM = { /* LUN not ready, medium removal prevented */ const struct SCSISense sense_code_NOT_READY_REMOVAL_PREVENTED = { - .key = NOT_READY, .asc = 0x53, .ascq = 0x00 + .key = NOT_READY, .asc = 0x53, .ascq = 0x02 }; /* Hardware error, internal target failure */ @@ -1129,7 +1129,7 @@ const struct SCSISense sense_code_INCOMPATIBLE_FORMAT = { /* Illegal request, medium removal prevented */ const struct SCSISense sense_code_ILLEGAL_REQ_REMOVAL_PREVENTED = { - .key = ILLEGAL_REQUEST, .asc = 0x53, .ascq = 0x00 + .key = ILLEGAL_REQUEST, .asc = 0x53, .ascq = 0x02 }; /* Command aborted, I/O process terminated */ -- 1.7.3.1