qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Li Zhang <zhlcindy@gmail.com>,
	qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] pseries: Instantiate USB if requested
Date: Tue, 31 Jul 2012 17:36:17 +1000	[thread overview]
Message-ID: <1343720177.16975.2.camel@pasglop> (raw)
In-Reply-To: <1343714945-20726-3-git-send-email-david@gibson.dropbear.id.au>

On Tue, 2012-07-31 at 16:09 +1000, David Gibson wrote:
> The pseries machine currently ignores the -usb command line option.
> This patch corrects the problem by having it instantiate a PCI OHCI
> USB host controller when -usb is specified.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Same comment as the -vga patch, Li's been dealing with that lately,
Li, can you update us on the status of those patches ?

Cheers,
Ben.

> ---
>  hw/spapr.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/hw/spapr.c b/hw/spapr.c
> index ab5a0c2..740881b 100644
> --- a/hw/spapr.c
> +++ b/hw/spapr.c
> @@ -45,6 +45,7 @@
>  #include "kvm.h"
>  #include "kvm_ppc.h"
>  #include "pci.h"
> +#include "usb.h"
>  
>  #include "exec-memory.h"
>  
> @@ -710,6 +711,12 @@ static void ppc_spapr_init(ram_addr_t ram_size,
>          spapr_vscsi_create(spapr->vio_bus);
>      }
>  
> +    /* USB */
> +    if (usb_enabled) {
> +        pci_create_simple(QLIST_FIRST(&spapr->phbs)->host_state.bus,
> +                          -1, "pci-ohci");
> +    }
> +
>      if (rma_size < (MIN_RMA_SLOF << 20)) {
>          fprintf(stderr, "qemu: pSeries SLOF firmware requires >= "
>                  "%ldM guest RMA (Real Mode Area memory)\n", MIN_RMA_SLOF);

  parent reply	other threads:[~2012-07-31  7:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31  6:09 [Qemu-devel] [0/5] Assorted pseries fixes and updates David Gibson
2012-07-31  6:09 ` [Qemu-devel] [PATCH 1/5] pseries: Update SLOF David Gibson
2012-07-31  6:09 ` [Qemu-devel] [PATCH 2/5] pseries: Instantiate USB if requested David Gibson
2012-07-31  7:35   ` Benjamin Herrenschmidt
2012-07-31  7:36   ` Benjamin Herrenschmidt [this message]
2012-08-04  7:34     ` Li Zhang
2012-07-31  6:09 ` [Qemu-devel] [PATCH 3/5] pseries: Add support for -vga option David Gibson
2012-07-31  6:09 ` [Qemu-devel] [PATCH 4/5] pseries: Remove extraneous prints David Gibson
2012-07-31  6:09 ` [Qemu-devel] [PATCH 5/5] pseries: Add support for new KVM hash table control call David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343720177.16975.2.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=zhlcindy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).