From: Lei Li <lilei@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com,
Lei Li <lilei@linux.vnet.ibm.com>
Subject: [Qemu-devel] [RFC PATCH 2/4] monitor: Adjust qmp_human_monitor_command to new MemCharDriver
Date: Wed, 1 Aug 2012 17:48:56 +0800 [thread overview]
Message-ID: <1343814538-27591-3-git-send-email-lilei@linux.vnet.ibm.com> (raw)
In-Reply-To: <1343814538-27591-1-git-send-email-lilei@linux.vnet.ibm.com>
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
monitor.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/monitor.c b/monitor.c
index 49dccfe..c1a4d81 100644
--- a/monitor.c
+++ b/monitor.c
@@ -645,7 +645,13 @@ char *qmp_human_monitor_command(const char *command_line, bool has_cpu_index,
CharDriverState mchar;
memset(&hmp, 0, sizeof(hmp));
- qemu_chr_init_mem(&mchar);
+
+ /* Since the backend of MemCharDriver convert to a circular
+ * buffer with fixed size, so should indicate the init memory
+ * size.
+ *
+ * XXX: is 4096 as init memory enough for this? */
+ qemu_chr_init_mem(&mchar, 4096);
hmp.chr = &mchar;
old_mon = cur_mon;
--
1.7.7.6
next prev parent reply other threads:[~2012-08-01 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 9:48 [Qemu-devel] [RFC PATCH 0/4] char: expose MemoryCharDriver to users and provide QMP interface Lei Li
2012-08-01 9:48 ` [Qemu-devel] [RFC PATCH 1/4] qemu-char: Convert MemCharDriver to circular buffer Lei Li
2012-08-01 21:30 ` Anthony Liguori
2012-08-06 10:57 ` Lei Li
2012-08-01 9:48 ` Lei Li [this message]
2012-08-01 9:48 ` [Qemu-devel] [RFC PATCH 3/4] qmp: Introduce memchar_write QMP command Lei Li
2012-08-01 15:50 ` Eric Blake
2012-08-01 21:33 ` Anthony Liguori
2012-08-01 9:48 ` [Qemu-devel] [RFC PATCH 4/4] qmp: Introduce memchar_read " Lei Li
2012-08-01 15:51 ` Eric Blake
2012-08-01 21:39 ` [Qemu-devel] [RFC PATCH 0/4] char: expose MemoryCharDriver to users and provide QMP interface Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343814538-27591-3-git-send-email-lilei@linux.vnet.ibm.com \
--to=lilei@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).