qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 08/19] net: Remove vlan code from net.c
Date: Wed,  1 Aug 2012 13:54:40 +0100	[thread overview]
Message-ID: <1343825691-343-9-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1343825691-343-1-git-send-email-stefanha@linux.vnet.ibm.com>

The vlan implementation in net.c has been replaced by hubs so we can
remove the code.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
---
 hw/xen_nic.c |    1 -
 net.c        |  108 ----------------------------------------------------------
 net.h        |    1 -
 3 files changed, 110 deletions(-)

diff --git a/hw/xen_nic.c b/hw/xen_nic.c
index 593a572..5c3c1c6 100644
--- a/hw/xen_nic.c
+++ b/hw/xen_nic.c
@@ -325,7 +325,6 @@ static int net_init(struct XenDevice *xendev)
         return -1;
     }
 
-    netdev->conf.vlan = qemu_find_vlan(netdev->xendev.dev, 1);
     netdev->conf.peer = NULL;
 
     netdev->nic = qemu_new_nic(&net_xen_info, &netdev->conf,
diff --git a/net.c b/net.c
index 274f3bd..819fff7 100644
--- a/net.c
+++ b/net.c
@@ -391,50 +391,6 @@ static ssize_t qemu_deliver_packet(VLANClientState *sender,
     return ret;
 }
 
-static ssize_t qemu_vlan_deliver_packet(VLANClientState *sender,
-                                        unsigned flags,
-                                        const uint8_t *buf,
-                                        size_t size,
-                                        void *opaque)
-{
-    VLANState *vlan = opaque;
-    VLANClientState *vc;
-    ssize_t ret = -1;
-
-    QTAILQ_FOREACH(vc, &vlan->clients, next) {
-        ssize_t len;
-
-        if (vc == sender) {
-            continue;
-        }
-
-        if (vc->link_down) {
-            ret = size;
-            continue;
-        }
-
-        if (vc->receive_disabled) {
-            ret = 0;
-            continue;
-        }
-
-        if (flags & QEMU_NET_PACKET_FLAG_RAW && vc->info->receive_raw) {
-            len = vc->info->receive_raw(vc, buf, size);
-        } else {
-            len = vc->info->receive(vc, buf, size);
-        }
-
-        if (len == 0) {
-            vc->receive_disabled = 1;
-        }
-
-        ret = (ret >= 0) ? ret : len;
-
-    }
-
-    return ret;
-}
-
 void qemu_purge_queued_packets(VLANClientState *vc)
 {
     NetQueue *queue;
@@ -541,42 +497,6 @@ static ssize_t qemu_deliver_packet_iov(VLANClientState *sender,
     }
 }
 
-static ssize_t qemu_vlan_deliver_packet_iov(VLANClientState *sender,
-                                            unsigned flags,
-                                            const struct iovec *iov,
-                                            int iovcnt,
-                                            void *opaque)
-{
-    VLANState *vlan = opaque;
-    VLANClientState *vc;
-    ssize_t ret = -1;
-
-    QTAILQ_FOREACH(vc, &vlan->clients, next) {
-        ssize_t len;
-
-        if (vc == sender) {
-            continue;
-        }
-
-        if (vc->link_down) {
-            ret = iov_size(iov, iovcnt);
-            continue;
-        }
-
-        assert(!(flags & QEMU_NET_PACKET_FLAG_RAW));
-
-        if (vc->info->receive_iov) {
-            len = vc->info->receive_iov(vc, iov, iovcnt);
-        } else {
-            len = vc_sendv_compat(vc, iov, iovcnt);
-        }
-
-        ret = (ret >= 0) ? ret : len;
-    }
-
-    return ret;
-}
-
 ssize_t qemu_sendv_packet_async(VLANClientState *sender,
                                 const struct iovec *iov, int iovcnt,
                                 NetPacketSent *sent_cb)
@@ -604,34 +524,6 @@ qemu_sendv_packet(VLANClientState *vc, const struct iovec *iov, int iovcnt)
     return qemu_sendv_packet_async(vc, iov, iovcnt, NULL);
 }
 
-/* find or alloc a new VLAN */
-VLANState *qemu_find_vlan(int id, int allocate)
-{
-    VLANState *vlan;
-
-    QTAILQ_FOREACH(vlan, &vlans, next) {
-        if (vlan->id == id) {
-            return vlan;
-        }
-    }
-
-    if (!allocate) {
-        return NULL;
-    }
-
-    vlan = g_malloc0(sizeof(VLANState));
-    vlan->id = id;
-    QTAILQ_INIT(&vlan->clients);
-
-    vlan->send_queue = qemu_new_net_queue(qemu_vlan_deliver_packet,
-                                          qemu_vlan_deliver_packet_iov,
-                                          vlan);
-
-    QTAILQ_INSERT_TAIL(&vlans, vlan, next);
-
-    return vlan;
-}
-
 VLANClientState *qemu_find_netdev(const char *id)
 {
     VLANClientState *vc;
diff --git a/net.h b/net.h
index 4bccead..9393e4d 100644
--- a/net.h
+++ b/net.h
@@ -76,7 +76,6 @@ struct VLANState {
     NetQueue *send_queue;
 };
 
-VLANState *qemu_find_vlan(int id, int allocate);
 VLANClientState *qemu_find_netdev(const char *id);
 VLANClientState *qemu_new_net_client(NetClientInfo *info,
                                      VLANClientState *peer,
-- 
1.7.10.4

  parent reply	other threads:[~2012-08-01 12:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-01 12:54 [Qemu-devel] [PULL 00/19] Net patches for QEMU 1.2 Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 01/19] net: Add interface to bridge when SIOCBRADDIF isn't available Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 02/19] net: Add a hub net client Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 03/19] net: Use hubs for the vlan feature Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 04/19] net: Look up 'vlan' net clients using hubs Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 05/19] hub: Check that hubs are configured correctly Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 06/19] net: Drop vlan argument to qemu_new_net_client() Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 07/19] net: Convert qdev_prop_vlan to peer with hub Stefan Hajnoczi
2012-08-01 12:54 ` Stefan Hajnoczi [this message]
2012-08-01 12:54 ` [Qemu-devel] [PATCH 09/19] net: Remove VLANState Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 10/19] net: Rename non_vlan_clients to net_clients Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 11/19] net: Rename VLANClientState to NetClientState Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 12/19] net: Rename vc local variables to nc Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 13/19] net: Rename qemu_del_vlan_client() to qemu_del_net_client() Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 14/19] net: Make "info network" output more readable info Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 15/19] net: cleanup deliver/deliver_iov func pointers Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 16/19] net: determine if packets can be sent before net queue deliver packets Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 17/19] hub: add the support for hub own flow control Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 18/19] net: fix the coding style Stefan Hajnoczi
2012-08-01 12:54 ` [Qemu-devel] [PATCH 19/19] net: add the support for -netdev socket, listen Stefan Hajnoczi
2012-08-03 20:44 ` [Qemu-devel] [PULL 00/19] Net patches for QEMU 1.2 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343825691-343-9-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wuzhy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).